Add new package `@wordpress/stylelint config` #22777

ntwb · 2020-05-31T06:23:47Z

Description

Migrates the WordPress-Coding-Standards/stylelint-config-wordpress into this repo as a new @wordpress/stylelint-config package using lerna import

Import Repo

Using Lerna the existing git repo was imported using:

lerna import ../stylelint-config-wordpress/ --flatten
lerna info About to import 320 commits from ../stylelint-config-wordpress/ into packages/stylelint-config-wordpress

Note: As such this PR includes a lot of commits, the oldest 320 commits are from the legacy repo

Testing

To test run the following standalone tests:

Change to the repo root
Remove node_modules, rm -rf node_modules
Run npm install
Run npm run build
Run npm run lint-css from the repo root
Run npm run test-unit from the repo root

ToDo

The legacy code is licensed under MIT, can discuss switching to GPL
Update the package author field
Update readme
Update changelog
Rewrite changelog in packages markdown format
Add wp-scripts format-css

Update packages per /packages#managing-dependencies

Update root packages
Update @wordpress/scripts packages

How has this been tested?

Screenshots

Types of changes

Checklist:

My code is tested.
My code follows the WordPress code style.
My code follows the accessibility standards.
My code has proper inline documentation.
I've included developer documentation if appropriate.
I've updated all React Native files affected by any refactorings/renamings in this PR.

…g-end-of-source-newline` rule instead. (#84)

…s`. (#85)

)

* feat: Add SCSS preset config * fix: Include README.md and scss.js in package.json files list * test: Add initial SCSS tests

… a promise and move css code out of tests to individual files * feat: Use ECMAScript 8/2017 * refactor: Use async/await instead of returning a promise and move css code out of tests to individual files

https://greenkeeper.io/

* chore(package): update ava to version 0.17.0 * refactor: Include path to test fixtures https://greenkeeper.io/

https://greenkeeper.io/

* chore(package): update eslint-config-stylelint to version 6.0.0 * refactor: Update tests per latest `eslint-config-stylelint`

…118) * chore: Drop NodeJS from Travis CI * chore: Drop NodeJS from AppVeyor * chore: Bump minimum NodeJS requirement to 6.9.1

gziolo · 2020-12-15T10:12:14Z

@ntwb, would be best to answer the version question. In the past, we migrated other packages and applied the major version bump. I don't mind following the same approach here.

ocean90 · 2020-12-15T10:32:38Z

and applied the major version bump. I don't mind following the same approach here.

So that would be 18.0.0? That works for me too. This would also allow us to reduce the version constraints in peerDependencies so we can publish this with the fix from WordPress-Coding-Standards/stylelint-config-wordpress#267.

gziolo

Overall, it looks like it's ready to merge. It's hard to tell if functionality wise everything is correct as I have no idea what the package contains as of today. If @ntwb or anyone else maintaining is happy then I'm happy as well 😃

packages/stylelint-config/package.json

packages/stylelint-config/CHANGELOG.md

gziolo · 2020-12-16T09:59:51Z

packages/stylelint-config/LICENSE

@@ -0,0 +1,22 @@
+The MIT License (MIT)


Is this license file necessary? It looks like a standard one. I have no idea myself, just asking. We don't put copies for "GPL-2.0-or-later" in other packages.

Good question, I'm not sure either. Wondering who would be best to answer this?

At least the license itself says, that it should be included. But the copyright info is actually a bit odd. 🤷🏻‍♂️

packages/stylelint-config/__tests__/commenting.test.js

packages/stylelint-config/scss.js

gziolo · 2020-12-16T10:06:59Z

I left a few more nitpicks among which I care mostly about the version bump one 😄 Once it's addressed I'm happy to approve this PR based on my limited knowledge as raised in the previous comment.

gziolo · 2020-12-17T07:03:58Z

I have just published WordPress packages to npm. When running wp-scripts lint-style I see the following error:

Deprecation Warning: 'declaration-property-unit-whitelist' has been deprecated. Instead use 'declaration-property-unit-allowed-list'. See: https://github.com/stylelint/stylelint/blob/13.7.0/lib/rules/declaration-property-unit-whitelist/README.md

Is it covered in this PR? If not, I opened an issue: #27775.

ocean90 · 2020-12-17T07:06:53Z

@gziolo Yes and no, referencing #22777 (comment) again.

gziolo

Once CI is green this PR should be good to go. Some e2e tests became unstable but changes proposed here should not have impact on them at all. You might need to restart them when they fail.

ocean90 · 2020-12-18T08:08:27Z

@gziolo I can't get End-to-End Tests / Admin - 3 (pull_request) passing, I guess that's ok for now?

gziolo · 2020-12-18T08:29:25Z

Yes, it's failing on the majority CI checks now 🤷‍♂️

I merged PR regardless 😃

ntwb and others added 30 commits May 31, 2020 15:33

chore(package): update stylelint to version 7.0.0 (#83)

2a8cb6d

fix: Deprecated no-missing-eof-newline rule. Use the new `no-missin…

1c5d175

…g-end-of-source-newline` rule instead. (#84)

fix: Fixed font-family-name-quotes test warning message in values.j…

90cc185

…s`. (#85)

feat: Add property-no-unknown rule. (#86)

f432fe9

Update install instructions to add --save-dev

553397b

chore(package): update stylelint to version 7.2.0 (#87)

82a8f7e

chore(package): update AVA to version 0.16.0 (#88)

d15a1c3

chore(package): update eslint-config-stylelint to version 4.0.0 (#89)

9adab0f

chore(package): update ESLint to version 3.0.0 (#90)

3a5c26b

feat: Add at-rule-no-unknown rule. (#91)

eebd971

feat: Add selector-class-pattern and selector-id-pattern rules. (#92

2def9cd

)

Prepare 9.0.0

078ac5f

Merge branch 'master' of github.com:ntwb/stylelint-config-wordpress

b70ece2

feat: Add SCSS preset config (#96)

413e48e

* feat: Add SCSS preset config * fix: Include README.md and scss.js in package.json files list * test: Add initial SCSS tests

Prepare 9.1.0

8261a33

Prepare 9.1.1

db3001e

refactor: Use ECMAScript 8/2017, use async/await instead of returning…

da15333

… a promise and move css code out of tests to individual files * feat: Use ECMAScript 8/2017 * refactor: Use async/await instead of returning a promise and move css code out of tests to individual files

chore(package): update dependencies (#100)

5321d45

https://greenkeeper.io/

chore: Add NodeJS 7 to Travis & AppVeyor CI test matrix's (#102)

fa79be4

chore(package): update stylelint to version 7.5.0 (#103)

bac1b91

chore: Add NodeJS 7.x changelog note

430bf84

feat: Add selector-no-empty rule. (#104)

0dcd082

chore(package): Update eslint-plugin-ava to version 4.0.0 (#105)

08333a3

fix: SCSS: Dissalow @debug at-rules.

4f55051

fix: SCSS: Add scss/selector-no-redundant-nesting-selector rule.

b27c6fc

Update ava to the latest version 🚀 (#109)

c7b5e4b

* chore(package): update ava to version 0.17.0 * refactor: Include path to test fixtures https://greenkeeper.io/

chore(package): update npm-run-all to version 4.0.0 (#111)

269a04f

https://greenkeeper.io/

Update eslint-config-stylelint to the latest version 🚀 (#110)

34a2b85

* chore(package): update eslint-config-stylelint to version 6.0.0 * refactor: Update tests per latest `eslint-config-stylelint`

chore: bump minimum NodeJS requirement to 6.9.1 and drop NodeJS 4.x (#…

4c65b5b

…118) * chore: Drop NodeJS from Travis CI * chore: Drop NodeJS from AppVeyor * chore: Bump minimum NodeJS requirement to 6.9.1

chore: Update remark and remark plugin packages (#120)

d991aa9

ocean90 added 3 commits December 15, 2020 21:29

Backfill release dates in changelog

64007e5

Update package author

64a43f8

Update readme

8eec3d6

ocean90 marked this pull request as ready for review December 15, 2020 21:02

ocean90 requested review from ajitbohra and chrisvanpatten as code owners December 15, 2020 21:02

gziolo reviewed Dec 15, 2020

View reviewed changes

packages/stylelint-config/package.json Show resolved Hide resolved

gziolo reviewed Dec 16, 2020

View reviewed changes

packages/stylelint-config/CHANGELOG.md Show resolved Hide resolved

gziolo reviewed Dec 16, 2020

View reviewed changes

packages/stylelint-config/__tests__/commenting.test.js Outdated Show resolved Hide resolved

gziolo reviewed Dec 16, 2020

View reviewed changes

packages/stylelint-config/scss.js Outdated Show resolved Hide resolved

ocean90 added 4 commits December 17, 2020 21:16

Update comment to use renamed package name

490cde8

Rename tests to match other packages

3c4ab8f

Remove stylelint ^10.1.0, ^11.0.0, and ^12.0.0 as peer dependency.

3aa8939

Merge branch 'master' into try/stylelint-config-package

0605d8b

gziolo approved these changes Dec 17, 2020

View reviewed changes

gziolo merged commit 9367df0 into master Dec 18, 2020

gziolo deleted the try/stylelint-config-package branch December 18, 2020 08:28

github-actions bot added this to the Gutenberg 9.7 milestone Dec 18, 2020

ocean90 mentioned this pull request Dec 18, 2020

Use @wordpress/stylelint-config in @wordpress/scripts #27810

Merged

4 tasks

ocean90 mentioned this pull request Jan 4, 2021

Create new release to ship latest changes WordPress-Coding-Standards/stylelint-config-wordpress#268

Closed

miguelpeixe mentioned this pull request Aug 24, 2021

feat: add settings page, and show placeholder if no credit Automattic/newspack-image-credits#9

Merged

mchowning mentioned this pull request Dec 14, 2021

Dual-Licensing Gutenberg: Should we keep some code GPL-only #29483

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add new package `@wordpress/stylelint config` #22777

Add new package `@wordpress/stylelint config` #22777

ntwb commented May 31, 2020 •

edited

Loading

gziolo commented Dec 15, 2020

ocean90 commented Dec 15, 2020

gziolo left a comment

gziolo Dec 16, 2020

ocean90 Dec 16, 2020

gziolo commented Dec 16, 2020

gziolo commented Dec 17, 2020

ocean90 commented Dec 17, 2020

gziolo left a comment

ocean90 commented Dec 18, 2020

gziolo commented Dec 18, 2020

Add new package @wordpress/stylelint config #22777

Add new package @wordpress/stylelint config #22777

Conversation

ntwb commented May 31, 2020 • edited Loading

Description

Import Repo

Testing

ToDo

How has this been tested?

Screenshots

Types of changes

Checklist:

gziolo commented Dec 15, 2020

ocean90 commented Dec 15, 2020

gziolo left a comment

Choose a reason for hiding this comment

gziolo Dec 16, 2020

Choose a reason for hiding this comment

ocean90 Dec 16, 2020

Choose a reason for hiding this comment

gziolo commented Dec 16, 2020

gziolo commented Dec 17, 2020

ocean90 commented Dec 17, 2020

gziolo left a comment

Choose a reason for hiding this comment

ocean90 commented Dec 18, 2020

gziolo commented Dec 18, 2020

Add new package `@wordpress/stylelint config` #22777

Add new package `@wordpress/stylelint config` #22777

ntwb commented May 31, 2020 •

edited

Loading