E2E Tests: Specify icon for block context test blocks #22811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
[Type] Bug
|
Size Change: 0 B Total Size: 1.11 MB ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #22810
This pull request is intended to serve as a temporary fix for the issue described at #22810.
Specifically, it ensures that a block icon is provided for the block context blocks so that the default empty string value does not take effect, where in WordPress trunk environments it will be flagged as invalid.
iconshould be considered as optional, so technically this change should not be required, but is intended to serve as a temporary fix to allow builds to fail until a more permanent resolution can be implemented for #22810.The icon chosen is arbitrary.
Testing Instructions:
Ensure end-to-end tests pass:
Follow-up Tasks:
Once a permanent resolution is addressed for #22810, these changes should ideally be reverted, as apparently they serve as indirect verification of the default block registrations. Alternatively, a test dedicated to verifying these behaviors should be implemented.