-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Panel for navigation structure on small screens only #22828
Merged
adamziel
merged 3 commits into
master
from
update/use-panel-for-navigation-only-on-mobile
Jun 3, 2020
Merged
Use Panel for navigation structure on small screens only #22828
adamziel
merged 3 commits into
master
from
update/use-panel-for-navigation-only-on-mobile
Jun 3, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: +87 B (0%) Total Size: 1.12 MB
ℹ️ View Unchanged
|
6 tasks
Works as expected. |
@shaunandrews Approvy-approve please? |
shaunandrews
approved these changes
Jun 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The navigation structure uses the Panel component to make it possible for mobile clients to quickly skip it and scroll down. On larger screens, it is placed to the left of the menu preview on large screens and the usage of Panel does not make sense as much. This PR uses Card on larger screens and Panel on smaller ones.
How has this been tested?
Screenshots
Small screen:

Large screen:

Types of changes
Non-breaking change
Checklist: