Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block Library: Fix React does not recognize isSelected prop in ComplementaryAreaToggle. #22967

Merged
merged 2 commits into from
Jun 18, 2020
Merged

Block Library: Fix React does not recognize isSelected prop in ComplementaryAreaToggle. #22967

merged 2 commits into from
Jun 18, 2020

Conversation

torounit
Copy link
Member

@torounit torounit commented Jun 6, 2020

Description

fix error Warning: React does not recognize the isSelected prop on a DOM element.

Warning: React does not recognize the `isSelected` prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase `isselected` instead. If you accidentally passed it from a parent component, remove it from the DOM element.
    in button (created by ForwardRef(Button))
    in Tooltip (created by ForwardRef(Button))
    in ForwardRef(Button) (created by ComplementaryAreaToggle)
    in ComplementaryAreaToggle (created by Context.Consumer)
...

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@github-actions
Copy link

github-actions bot commented Jun 6, 2020 •
edited
Loading

Size Change: +7.29 kB (0%)

Total Size: 1.13 MB

Filename Size Change
build/annotations/index.js 3.62 kB +2 B (0%)
build/block-directory/index.js 7.27 kB +519 B (7%) 🔍
build/block-editor/index.js 106 kB +220 B (0%)
build/block-editor/style-rtl.css 12.1 kB +742 B (6%) 🔍
build/block-editor/style.css 12.1 kB +737 B (6%) 🔍
build/block-library/editor-rtl.css 7.88 kB +15 B (0%)
build/block-library/editor.css 7.89 kB +13 B (0%)
build/block-library/index.js 129 kB +1.94 kB (1%)
build/block-library/style-rtl.css 7.96 kB +240 B (3%)
build/block-library/style.css 7.96 kB +244 B (3%)
build/block-serialization-default-parser/index.js 1.88 kB -1 B
build/block-serialization-spec-parser/index.js 3.1 kB +1 B
build/blocks/index.js 48.1 kB -3 B (0%)
build/components/index.js 195 kB +1.94 kB (0%)
build/compose/index.js 9.32 kB +6 B (0%)
build/core-data/index.js 11.4 kB -10 B (0%)
build/data/index.js 8.44 kB -11 B (0%)
build/deprecated/index.js 772 B +1 B
build/dom/index.js 3.17 kB -1 B
build/edit-navigation/index.js 8.26 kB +8 B (0%)
build/edit-navigation/style-rtl.css 974 B +56 B (5%) 🔍
build/edit-navigation/style.css 974 B +55 B (5%) 🔍
build/edit-post/index.js 302 kB -58 B (0%)
build/edit-post/style-rtl.css 5.6 kB +168 B (3%)
build/edit-post/style.css 5.6 kB +168 B (3%)
build/edit-site/index.js 16.6 kB +1.09 kB (6%) 🔍
build/edit-widgets/index.js 9.33 kB -3 B (0%)
build/editor/editor-styles-rtl.css 423 B -2 B (0%)
build/editor/editor-styles.css 423 B -5 B (1%)
build/editor/index.js 44.8 kB +57 B (0%)
build/format-library/index.js 7.72 kB +1 B
build/hooks/index.js 2.13 kB -3 B (0%)
build/html-entities/index.js 622 B +1 B
build/is-shallow-equal/index.js 710 B -1 B
build/keyboard-shortcuts/index.js 2.51 kB -7 B (0%)
build/list-reusable-blocks/index.js 3.13 kB +4 B (0%)
build/media-utils/index.js 5.29 kB -5 B (0%)
build/notices/index.js 1.79 kB +1 B
build/nux/index.js 3.4 kB -8 B (0%)
build/plugins/index.js 2.56 kB +2 B (0%)
build/primitives/index.js 1.5 kB -2 B (0%)
build/rich-text/index.js 14 kB -805 B (5%) ✅
build/token-list/index.js 1.28 kB -1 B
build/viewport/index.js 1.85 kB -1 B
build/warning/index.js 1.14 kB +1 B
build/wordcount/index.js 1.17 kB -1 B
ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.14 kB 0 B
build/api-fetch/index.js 3.4 kB 0 B
build/autop/index.js 2.83 kB 0 B
build/blob/index.js 620 B 0 B
build/block-directory/style-rtl.css 892 B 0 B
build/block-directory/style.css 892 B 0 B
build/block-library/theme-rtl.css 684 B 0 B
build/block-library/theme.css 686 B 0 B
build/components/style-rtl.css 19.5 kB 0 B
build/components/style.css 19.5 kB 0 B
build/data-controls/index.js 1.29 kB 0 B
build/date/index.js 5.47 kB 0 B
build/dom-ready/index.js 568 B 0 B
build/edit-site/style-rtl.css 2.96 kB 0 B
build/edit-site/style.css 2.96 kB 0 B
build/edit-widgets/style-rtl.css 2.4 kB 0 B
build/edit-widgets/style.css 2.4 kB 0 B
build/editor/style-rtl.css 4.26 kB 0 B
build/editor/style.css 4.27 kB 0 B
build/element/index.js 4.64 kB 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/style-rtl.css 502 B 0 B
build/format-library/style.css 502 B 0 B
build/i18n/index.js 3.56 kB 0 B
build/keycodes/index.js 1.94 kB 0 B
build/list-reusable-blocks/style-rtl.css 226 B 0 B
build/list-reusable-blocks/style.css 226 B 0 B
build/nux/style-rtl.css 616 B 0 B
build/nux/style.css 613 B 0 B
build/priority-queue/index.js 789 B 0 B
build/redux-routine/index.js 2.85 kB 0 B
build/server-side-render/index.js 2.68 kB 0 B
build/shortcode/index.js 1.7 kB 0 B
build/url/index.js 4.06 kB 0 B

compressed-size-action

@torounit torounit added the [Package] Interface /packages/interface label Jun 10, 2020
youknowriad
youknowriad reviewed Jun 15, 2020
View reviewed changes
packages/interface/src/components/complementary-area-toggle/index.js
return (
<ComponentToUse
icon={ selectedIcon && isSelected ? selectedIcon : icon }
isSelected={ isSelected }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should just remove it? Is it useful anywhere?

If I understand properly the components that can be used as as should follow the same API as buttons.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's better that way. I'll do it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@youknowriad fixed 👍

youknowriad
youknowriad approved these changes Jun 16, 2020
View reviewed changes
Copy link
Contributor

@youknowriad youknowriad left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@torounit torounit mentioned this pull request Jun 18, 2020
Merged
@gziolo
Copy link
Member

gziolo commented Jun 18, 2020 •
edited
Loading

Fixes comment from #21430

@gziolo gziolo merged commit 8828d9c into master Jun 18, 2020
@gziolo gziolo deleted the fix/isSelected-ComplementaryAreaToggle branch June 18, 2020 05:09
@github-actions github-actions bot added this to the Gutenberg 8.4 milestone Jun 18, 2020
This was referenced Jun 24, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youknowriad youknowriad youknowriad approved these changes

@jorgefilipecosta jorgefilipecosta Awaiting requested review from jorgefilipecosta

Assignees
No one assigned
Labels
[Package] Interface /packages/interface
Projects
None yet
Milestone
Gutenberg 8.4
Development

Successfully merging this pull request may close these issues.
3 participants
@torounit @gziolo @youknowriad