Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MediaPlaceholder: add onFilesPreUpload property #23003

Merged
merged 2 commits into from
Jun 10, 2020
Merged

MediaPlaceholder: add onFilesPreUpload property #23003

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f3e4b24
media-placerholder: add onFilesUpload property
retrofox Jun 8, 2020
60bdc28
rename prop name. Update doc
retrofox Jun 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions packages/block-editor/src/components/media-placeholder/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,15 @@ Callback called when an upload error happens.
- Required: No
- Platform: Web

### onFilesPreUpload
Callback called before to start to upload the files.
It receives an array with the files to upload before to the final process. It means that it's possible these files couldn't be uploaded.

- Type: `Function`
- Required: No
- Default: `Function` noop
- Platform: Web

### onSelect

Callback called when the files are selected/uploaded.
Expand Down
3 changes: 3 additions & 0 deletions packages/block-editor/src/components/media-placeholder/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,10 @@ export class MediaPlaceholder extends Component {
multiple,
onError,
onSelect,
onFilesPreUpload = noop,
} = this.props;

onFilesPreUpload( files );
let setMedia;
if ( multiple ) {
if ( addToGallery ) {
Expand Down