Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRs to backport to Gutenberg 8.3 #23026

Merged
merged 7 commits into from
Jun 10, 2020
Merged

PRs to backport to Gutenberg 8.3 #23026

merged 7 commits into from
Jun 10, 2020

Commits on Jun 9, 2020

  1. Edit Site: Fix template lookup (#22954)

    ## Description
    This PR fixes two issues with template lookup:
    
    ### 1. Templates with `index.html` block template fallback
    
    When using a theme that came with an `index.html` but not with a `front-page.html` block template, the site editor would show the following `Notice: Undefined index: front-page in /var/www/html/wp-content/plugins/gutenberg/lib/edit-site-page.php on line 162`.
     
    The reason is that I was setting the wrong key here: https://github.com/WordPress/gutenberg/blob/710373b254fbcd15d524afdeb31da0d93c4defd4/lib/edit-site-page.php#L158
    
    This would use the name of the template that was _found_, not the name of the key that was looked for. So if we're looking up `front-page`, but don't find any template, and [thus fall](https://github.com/WordPress/gutenberg/blob/710373b254fbcd15d524afdeb31da0d93c4defd4/lib/template-loader.php#L226) back to `index`, the template will be stored under the `index` key, rather than the front-end one. 
    
    The fix for this is to use the template we were looking for as key (rather than the name of the template we actually found).
    
    ### 2. Templates without `index.html` block template fallback
    
    When using a theme that doesn't come with any block templates at all, we need to provide a blank `index` template when the user first opens the site editor (see [discussion](#22893 (comment))).
    
    Co-authored-by: Enrique Piqueras <epiqueras@users.noreply.github.com>
    2 people authored and oandregal committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    fe867fc View commit details
    Browse the repository at this point in the history
  2. Add style rule once (#23025)

    nosolosw authored and oandregal committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    5aae0c2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    cbd8168 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2020

  1. Configuration menu
    Copy the full SHA
    36a82b2 View commit details
    Browse the repository at this point in the history
  2. package-lock.json: Update (#23052)

    ockham authored and oandregal committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    edd887c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    50c02ef View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    395cecf View commit details
    Browse the repository at this point in the history