-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RichText: simplify withFormatTypes as hook #23145
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: -29 B (0%) Total Size: 1.17 MB
ℹ️ View Unchanged
|
ZebulanStanphill
added
[Type] Code Quality
Issues or PRs that relate to code quality
[Feature] Rich Text
Related to the Rich Text component that allows developers to render a contenteditable
[Package] Rich text
/packages/rich-text
labels
Jun 15, 2020
ellatrix
force-pushed
the
try/use-format-types
branch
from
June 15, 2020 12:03
35477c6
to
401e129
Compare
ellatrix
force-pushed
the
try/use-format-types
branch
from
September 28, 2020 10:46
401e129
to
e05e5a6
Compare
ellatrix
requested review from
cameronvoell,
etoledom and
guarani
as code owners
September 28, 2020 15:41
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] Rich Text
Related to the Rich Text component that allows developers to render a contenteditable
[Package] Rich text
/packages/rich-text
[Type] Code Quality
Issues or PRs that relate to code quality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
WIP. The goal is to drastically simplify as useFormatTypes and remove all the key prefixing. This is no longer needed because the values no longer need to be passed as props. Previously everything was flattened to prevent re-renders.
How has this been tested?
Screenshots
Types of changes
Checklist: