Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor: Extend PostTrashCheck with canUser() check for delete action #23174

Merged
merged 1 commit into from
Jun 22, 2020
Merged

Editor: Extend PostTrashCheck with canUser() check for delete action #23174

merged 1 commit into from
Jun 22, 2020

Conversation

ocean90
Copy link
Member

@ocean90 ocean90 commented Jun 15, 2020 •
edited
Loading

Description

Fixes #23144.

This is a version which doesn't require a new action-delete action on the resource.

How has this been tested?

  • Create a user with only read and edit_posts capabilities
  • Create a new post and notice that there's no longer a trash link.

For testing you can use WP-CLI to create a user "author" with the role "author_only_edit" which can only create/edit draft posts.

npx wp-env run cli wp role create author_only_edit AuthorOnlyEdit
npx wp-env run cli wp cap add author_only_edit read edit_posts
npx wp-env run cli wp user create author author@example.com
npx wp-env run cli wp user set-role author@example.com author_only_edit

Screenshots

Types of changes

Bug fix

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@ocean90 ocean90 added [Type] Bug An existing feature does not function as intended [Package] Editor /packages/editor labels Jun 15, 2020
@github-actions
Copy link

Size Change: +77 B (0%)

Total Size: 1.13 MB

Filename Size Change
build/editor/index.js 44.8 kB +77 B (0%)
ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.14 kB 0 B
build/annotations/index.js 3.62 kB 0 B
build/api-fetch/index.js 3.4 kB 0 B
build/autop/index.js 2.83 kB 0 B
build/blob/index.js 620 B 0 B
build/block-directory/index.js 7.27 kB 0 B
build/block-directory/style-rtl.css 892 B 0 B
build/block-directory/style.css 892 B 0 B
build/block-editor/index.js 106 kB 0 B
build/block-editor/style-rtl.css 12.1 kB 0 B
build/block-editor/style.css 12.1 kB 0 B
build/block-library/editor-rtl.css 7.88 kB 0 B
build/block-library/editor.css 7.89 kB 0 B
build/block-library/index.js 129 kB 0 B
build/block-library/style-rtl.css 7.96 kB 0 B
build/block-library/style.css 7.96 kB 0 B
build/block-library/theme-rtl.css 684 B 0 B
build/block-library/theme.css 686 B 0 B
build/block-serialization-default-parser/index.js 1.88 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/blocks/index.js 48.1 kB 0 B
build/components/index.js 195 kB 0 B
build/components/style-rtl.css 19.5 kB 0 B
build/components/style.css 19.5 kB 0 B
build/compose/index.js 9.32 kB 0 B
build/core-data/index.js 11.4 kB 0 B
build/data-controls/index.js 1.29 kB 0 B
build/data/index.js 8.44 kB 0 B
build/date/index.js 5.47 kB 0 B
build/deprecated/index.js 772 B 0 B
build/dom-ready/index.js 568 B 0 B
build/dom/index.js 3.17 kB 0 B
build/edit-navigation/index.js 8.26 kB 0 B
build/edit-navigation/style-rtl.css 975 B 0 B
build/edit-navigation/style.css 974 B 0 B
build/edit-post/index.js 302 kB 0 B
build/edit-post/style-rtl.css 5.6 kB 0 B
build/edit-post/style.css 5.6 kB 0 B
build/edit-site/index.js 16.6 kB 0 B
build/edit-site/style-rtl.css 2.96 kB 0 B
build/edit-site/style.css 2.96 kB 0 B
build/edit-widgets/index.js 9.34 kB 0 B
build/edit-widgets/style-rtl.css 2.4 kB 0 B
build/edit-widgets/style.css 2.4 kB 0 B
build/editor/editor-styles-rtl.css 423 B 0 B
build/editor/editor-styles.css 423 B 0 B
build/editor/style-rtl.css 4.26 kB 0 B
build/editor/style.css 4.27 kB 0 B
build/element/index.js 4.64 kB 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/index.js 7.72 kB 0 B
build/format-library/style-rtl.css 502 B 0 B
build/format-library/style.css 502 B 0 B
build/hooks/index.js 2.13 kB 0 B
build/html-entities/index.js 622 B 0 B
build/i18n/index.js 3.56 kB 0 B
build/is-shallow-equal/index.js 710 B 0 B
build/keyboard-shortcuts/index.js 2.51 kB 0 B
build/keycodes/index.js 1.94 kB 0 B
build/list-reusable-blocks/index.js 3.13 kB 0 B
build/list-reusable-blocks/style-rtl.css 226 B 0 B
build/list-reusable-blocks/style.css 226 B 0 B
build/media-utils/index.js 5.29 kB 0 B
build/notices/index.js 1.79 kB 0 B
build/nux/index.js 3.4 kB 0 B
build/nux/style-rtl.css 616 B 0 B
build/nux/style.css 613 B 0 B
build/plugins/index.js 2.56 kB 0 B
build/primitives/index.js 1.5 kB 0 B
build/priority-queue/index.js 789 B 0 B
build/redux-routine/index.js 2.85 kB 0 B
build/rich-text/index.js 14 kB 0 B
build/server-side-render/index.js 2.68 kB 0 B
build/shortcode/index.js 1.7 kB 0 B
build/token-list/index.js 1.28 kB 0 B
build/url/index.js 4.06 kB 0 B
build/viewport/index.js 1.85 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.17 kB 0 B

compressed-size-action

@ocean90 ocean90 requested a review from youknowriad June 19, 2020 13:46
youknowriad
youknowriad reviewed Jun 19, 2020
View reviewed changes
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Do you know how we can test this easily? How can I create such user?

packages/editor/src/components/post-trash/check.js
const { getPostType, canUser } = select( 'core' );
const postId = getCurrentPostId();
const postType = getPostType( getCurrentPostType() );
const resource = postType?.[ 'rest_base' ] || '';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I'd have avoided this temporary variable and just used postType in the check line 27.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, resource is used twice in line 27. Or do mean doing this instead?

postId && postType ? canUser( 'delete', postType[ 'rest_base' ], postId ) : false,

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, that's exactly what I meant. It's just a very small detail without importance though.

@ocean90
Copy link
Member Author

ocean90 commented Jun 19, 2020

How can I create such user?

@youknowriad I have extended the description with four WP-CLI commands to create the role and user for testing.

youknowriad
youknowriad approved these changes Jun 19, 2020
View reviewed changes
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ocean90 ocean90 merged commit 149a1e1 into master Jun 22, 2020
@ocean90 ocean90 deleted the fix/user-can-delete branch June 22, 2020 13:04
@github-actions github-actions bot added this to the Gutenberg 8.5 milestone Jun 22, 2020
@ocean90 ocean90 mentioned this pull request Jun 28, 2020
Closed
This was referenced Jul 21, 2021
Closed
Closed
@jorgefilipecosta jorgefilipecosta mentioned this pull request Jun 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youknowriad youknowriad youknowriad approved these changes

Assignees
No one assigned
Labels
[Package] Editor /packages/editor [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
Gutenberg 8.5
Development

Successfully merging this pull request may close these issues.

Don't show "Move to Trash" link if current user cannot delete posts
2 participants
@ocean90 @youknowriad