Use high-luminance colors in Gutenberg plugin #23313
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Enhancement
youknowriad
requested review from
spacedmonkey and
TimothyBJacobs
as code owners
|
Size Change: 0 B Total Size: 1.12 MB ℹ️ View Unchanged
|
youknowriad
force-pushed
the
update/gutenberg-colors
branch
from
fc19668
to
4de70ae
Compare
|
You're my favorite, Riad. Since the original PR, and since chatting with @pablohoneyhoney, I've come to the realization that although this is a nice blue with better and more accessible luminosity color, it just fragments if it's only the editor. However Matías mentioned on the other PR that we could make a new non-default wp-admin scheme that would apply not just to the edtior, but everywhere. This seems like an excellent way not only to bring more accessibile, luminous and fresh colors to the admin, but to test them out properly first. This PR could be part of that effort! I'm going to look into how this is achieved, it's been a while, and hopefully we can take it from there! |
|
It would really help those efforts, though, if I could get help getting the tests to pass on #23202 ;) — it changes the pattern for the sidebar heading colors. |
|
Thanks for the thoughts @jasmussen closing this for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR applies new default colors for the Gutenberg plugin. These colors won't apply to WordPress Core when backported because we need to ensure consistency with WordPress colors.
The idea is that we'll be able to quickly know whether the Gutenberg plugin is enabled or not.
Maybe longer term, consider using these colors in Core across WP Admin as these colors are better in terms of contrasts... (See #20460 for details).