-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the gutenberg-block-directory experimental flag #23389
Merged
noisysocks
merged 3 commits into
WordPress:master
from
tellyworth:update/block-directory-remove-experimental-flag
Jun 24, 2020
Merged
Remove the gutenberg-block-directory experimental flag #23389
noisysocks
merged 3 commits into
WordPress:master
from
tellyworth:update/block-directory-remove-experimental-flag
Jun 24, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like there's some e2e test failures. |
I don’t have your fork setup @tellyworth but we’ll probably want to the remove the following lines:
|
tellyworth
requested review from
ajitbohra,
nerrad,
ntwb and
talldan
as code owners
June 24, 2020 04:46
This removes the flag and its UI, enabling the block directory by default. Note that it does not change the API namespace, which is still `__experimental`.
tellyworth
force-pushed
the
update/block-directory-remove-experimental-flag
branch
from
June 24, 2020 04:52
b9a0206
to
533b1a9
Compare
noisysocks
approved these changes
Jun 24, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good and the tests pass!
StevenDufresne
approved these changes
Jun 24, 2020
github-actions
bot
added
the
First-time Contributor
Pull request opened by a first-time contributor to Gutenberg repository
label
Jun 24, 2020
noisysocks
pushed a commit
that referenced
this pull request
Jun 24, 2020
* Remove the gutenberg-block-directory experimental flag This removes the flag and its UI, enabling the block directory by default. Note that it does not change the API namespace, which is still `__experimental`. * Remove the experiment toggle in block directory e2e. * Move e2e tests into the editor folder and out of experiments. Co-authored-by: dufresnesteven <steve.dufresne@automattic.com>
This was referenced Jun 24, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
First-time Contributor
Pull request opened by a first-time contributor to Gutenberg repository
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the flag and its UI, enabling the block directory by default.
Note that it does not change the API namespace, which is still
__experimental
.See #23384.
How has this been tested?
Manually tested, by verifying that the block directory is searched from the editor:
boxer
,waves
, orbliss
.Types of changes
gutenberg-block-directory
experiment.Checklist: