Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the gutenberg-block-directory experimental flag #23389

Conversation

tellyworth
Copy link
Contributor

This removes the flag and its UI, enabling the block directory by default.

Note that it does not change the API namespace, which is still __experimental.

See #23384.

How has this been tested?

Manually tested, by verifying that the block directory is searched from the editor:

  1. Visit Posts / Add New Post
  2. Click Add Block
  3. In Search For A Block, typeboxer, waves, or bliss.
  4. Confirm that some blocks from the directory are shown, headed with the text "No blocks found in your library. These blocks can be downloaded and installed:"

Types of changes

  • Removes conditional checks for the gutenberg-block-directory experiment.
  • Removes the settings field.
  • Removes the related setup from phpunit bootstrap.
  • In short, enables the Block Directory by default.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@ellatrix
Copy link
Member

Looks like there's some e2e test failures.

@ellatrix ellatrix added this to the Gutenberg 8.4 milestone Jun 23, 2020
@StevenDufresne
Copy link
Contributor

I don’t have your fork setup @tellyworth but we’ll probably want to the remove the following lines:

import { useExperimentalFeatures } from '../../experimental-features';

useExperimentalFeatures( [ '#gutenberg-block-directory' ] );

tellyworth and others added 3 commits June 24, 2020 14:52
This removes the flag and its UI, enabling the block directory by default.

Note that it does not change the API namespace, which is still `__experimental`.
@tellyworth tellyworth force-pushed the update/block-directory-remove-experimental-flag branch from b9a0206 to 533b1a9 Compare June 24, 2020 04:52
Copy link
Member

@noisysocks noisysocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and the tests pass! :shipit:

@noisysocks noisysocks merged commit 5df2314 into WordPress:master Jun 24, 2020
@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Jun 24, 2020
noisysocks pushed a commit that referenced this pull request Jun 24, 2020
* Remove the gutenberg-block-directory experimental flag

This removes the flag and its UI, enabling the block directory by default.

Note that it does not change the API namespace, which is still `__experimental`.

* Remove the experiment toggle in block directory e2e.

* Move e2e tests into the editor folder and out of experiments.

Co-authored-by: dufresnesteven <steve.dufresne@automattic.com>
This was referenced Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants