-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the overflow on the button. #23409
Conversation
Size Change: -7 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
I've tried to remove this several times but I remember seeing issues in different buttons. Maybe it's not needed anymore though. We need to test properly. (Testing now) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I was not able to find any issues. cc @jasmussen for awareness.
@youknowriad Thanks for taking time to test, I appreciate it :) |
Description
This pr removes
overflow: hidden
from theButton
component to fix width issues.The buttons style were updated in #19058.
This issue was initially identified in that PR, in this conversation:
#19058 (comment)
It has also introduced issues in buttons used in the Block Directory package.
How to reproduce?
woocommerce
in the inserterScreenshots
How was this tested?
It was a total visual test. I navigated around look at the buttons to make sure everything is displayed properly.
Types of changes
Checklist: