Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Post content: show placeholder if trying to render itself #24010

Merged
merged 7 commits into from
Aug 31, 2020
Merged

Post content: show placeholder if trying to render itself #24010

merged 7 commits into from
Aug 31, 2020

Conversation

Addison-Stavlo
Copy link
Contributor

@Addison-Stavlo Addison-Stavlo commented Jul 16, 2020 •
edited by noahtallen
Loading

Fixes #22080, fixes #23762 (by stopping those crashes from occurring when a post content block exists.)

Related to #24006.

Description

  • Adds Placeholder content for Post Title block which displays when editing wp_template.
  • Adds placeholder for post content block, which displays when the root post is different from the post content (to avoid a crash. This works because there is no root post in FSE, but there is in all the other editors.)
  • Restructuring of how we pull props in the Query Loop component. This would break with a block error when loaded in the old editor due to lack of expected props being supplied through context. Now it just finds the posts without a supplied query.

Although it will show all posts retrieved from the entity records as there is no query to control or limit them. 🤔

How has this been tested?

locally in edit site, edit post (while editing posts and templates)

Screenshots

For the Singular template, instead of looking totally broken we get:

Screen Shot 2020-07-16 at 7 18 04 PM

(note that the post content placeholder has since been updated to look like this:)
Screen Shot 2020-07-20 at 3 02 53 PM

And for the Index template the broken query loop block:
Screen Shot 2020-07-16 at 5 57 49 PM

Shows posts:
Screen Shot 2020-07-16 at 5 57 05 PM

Types of changes

Bug fix, enhancement

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@Addison-Stavlo Addison-Stavlo changed the title WIP - placeholders and bypass queryloop errors WIP - Post content and query loop entity editor behavior goo. Jul 16, 2020
@Addison-Stavlo Addison-Stavlo self-assigned this Jul 16, 2020
@github-actions
Copy link

github-actions bot commented Jul 16, 2020 •
edited
Loading

Size Change: +630 B (0%)

Total Size: 1.17 MB

Filename Size Change
build/block-directory/index.js 7.99 kB +1 B
build/block-editor/index.js 126 kB +2 B (0%)
build/block-editor/style-rtl.css 10.8 kB +1 B
build/block-editor/style.css 10.8 kB +1 B
build/block-library/editor-rtl.css 8.55 kB +32 B (0%)
build/block-library/editor.css 8.55 kB +31 B (0%)
build/block-library/index.js 136 kB +498 B (0%)
build/block-library/style-rtl.css 7.47 kB +23 B (0%)
build/block-library/style.css 7.47 kB +16 B (0%)
build/block-library/theme-rtl.css 741 B +12 B (1%)
build/block-library/theme.css 742 B +12 B (1%)
build/blocks/index.js 47.7 kB -3 B (0%)
build/components/index.js 200 kB -4 B (0%)
build/edit-site/index.js 17 kB +6 B (0%)
build/edit-widgets/index.js 11.9 kB +44 B (0%)
build/edit-widgets/style-rtl.css 2.45 kB -5 B (0%)
build/edit-widgets/style.css 2.45 kB -5 B (0%)
build/editor/editor-styles-rtl.css 492 B -45 B (9%) ✅
build/editor/editor-styles.css 493 B -46 B (9%) ✅
build/editor/index.js 45.3 kB +29 B (0%)
build/editor/style-rtl.css 3.81 kB +14 B (0%)
build/editor/style.css 3.81 kB +14 B (0%)
build/format-library/index.js 7.71 kB +2 B (0%)
build/i18n/index.js 3.57 kB +1 B
build/keyboard-shortcuts/index.js 2.52 kB -1 B
build/nux/index.js 3.4 kB +1 B
build/shortcode/index.js 1.7 kB -1 B
ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.14 kB 0 B
build/annotations/index.js 3.67 kB 0 B
build/api-fetch/index.js 3.44 kB 0 B
build/autop/index.js 2.82 kB 0 B
build/blob/index.js 620 B 0 B
build/block-directory/style-rtl.css 953 B 0 B
build/block-directory/style.css 952 B 0 B
build/block-serialization-default-parser/index.js 1.88 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/components/style-rtl.css 15.7 kB 0 B
build/components/style.css 15.7 kB 0 B
build/compose/index.js 9.67 kB 0 B
build/core-data/index.js 12.3 kB 0 B
build/data-controls/index.js 1.29 kB 0 B
build/data/index.js 8.55 kB 0 B
build/date/index.js 5.38 kB 0 B
build/deprecated/index.js 772 B 0 B
build/dom-ready/index.js 568 B 0 B
build/dom/index.js 4.48 kB 0 B
build/edit-navigation/index.js 11.7 kB 0 B
build/edit-navigation/style-rtl.css 1.16 kB 0 B
build/edit-navigation/style.css 1.16 kB 0 B
build/edit-post/index.js 304 kB 0 B
build/edit-post/style-rtl.css 5.61 kB 0 B
build/edit-post/style.css 5.61 kB 0 B
build/edit-site/style-rtl.css 3.06 kB 0 B
build/edit-site/style.css 3.06 kB 0 B
build/element/index.js 4.65 kB 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/style-rtl.css 547 B 0 B
build/format-library/style.css 548 B 0 B
build/hooks/index.js 2.13 kB 0 B
build/html-entities/index.js 621 B 0 B
build/is-shallow-equal/index.js 710 B 0 B
build/keycodes/index.js 1.94 kB 0 B
build/list-reusable-blocks/index.js 3.12 kB 0 B
build/list-reusable-blocks/style-rtl.css 476 B 0 B
build/list-reusable-blocks/style.css 476 B 0 B
build/media-utils/index.js 5.32 kB 0 B
build/notices/index.js 1.79 kB 0 B
build/nux/style-rtl.css 671 B 0 B
build/nux/style.css 668 B 0 B
build/plugins/index.js 2.56 kB 0 B
build/primitives/index.js 1.41 kB 0 B
build/priority-queue/index.js 789 B 0 B
build/redux-routine/index.js 2.85 kB 0 B
build/rich-text/index.js 13.9 kB 0 B
build/server-side-render/index.js 2.77 kB 0 B
build/token-list/index.js 1.27 kB 0 B
build/url/index.js 4.06 kB 0 B
build/viewport/index.js 1.85 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.17 kB 0 B

compressed-size-action

@ockham ockham mentioned this pull request Jul 20, 2020
Closed
@noahtallen noahtallen force-pushed the update/entity-editor-behavior-for-post-content-and-query-loop branch from 59a692a to bea53c7 Compare July 20, 2020 21:11
@noahtallen
Copy link
Member

updated the placeholder style:

Screen Shot 2020-07-20 at 3 02 53 PM

@noahtallen
Copy link
Member

updated the placeholder style:

note that I'd love to get designs for these, but I feel like we can merge this "rough" one and it will be an improvement until we do have placeholder designs

@noahtallen noahtallen force-pushed the update/entity-editor-behavior-for-post-content-and-query-loop branch from 46b0f8e to 101f7b3 Compare July 22, 2020 21:08
@noahtallen noahtallen marked this pull request as ready for review July 22, 2020 21:09
@noahtallen noahtallen changed the title WIP - Post content and query loop entity editor behavior goo. Do not render post content block if context matches current post Jul 22, 2020
@noahtallen noahtallen added [Feature] Full Site Editing [Type] Bug An existing feature does not function as intended [Type] Enhancement A suggestion for improvement. labels Jul 22, 2020
@noahtallen noahtallen mentioned this pull request Aug 26, 2020
Closed
@noahtallen noahtallen force-pushed the update/entity-editor-behavior-for-post-content-and-query-loop branch from 53f05a4 to 12ebeb9 Compare August 27, 2020 00:40
@noahtallen
Copy link
Member

cc @youknowriad this could use a review!

noahtallen
noahtallen approved these changes Aug 31, 2020
View reviewed changes
Copy link
Member

@noahtallen noahtallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do it!

@noahtallen noahtallen changed the title Do not render post content block if context matches current post Post content: show placeholder if trying to render itself Aug 31, 2020
@noahtallen noahtallen merged commit 970e8e0 into master Aug 31, 2020
@noahtallen noahtallen deleted the update/entity-editor-behavior-for-post-content-and-query-loop branch August 31, 2020 17:58
@github-actions github-actions bot added this to the Gutenberg 9.0 milestone Aug 31, 2020
@youknowriad youknowriad mentioned this pull request Nov 30, 2020
Merged
4 tasks
This was referenced Mar 18, 2021
Merged
Closed
Closed
Merged
Closed
Merged
Closed
@ellatrix ellatrix mentioned this pull request May 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epiqueras epiqueras epiqueras left review comments

@youknowriad youknowriad youknowriad left review comments

@ockham ockham ockham left review comments

@noahtallen noahtallen noahtallen approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@Soean Soean Awaiting requested review from Soean

@talldan talldan Awaiting requested review from talldan

Assignees

@noahtallen noahtallen

@Addison-Stavlo Addison-Stavlo

Labels
[Type] Bug An existing feature does not function as intended [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
Gutenberg 9.0
5 participants
@Addison-Stavlo @noahtallen @ockham @youknowriad @epiqueras