Document settings: improve accessibility of "Status & visibility" controls #24024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZebulanStanphill
added
[Focus] Accessibility (a11y)
|
Size Change: -194 B (0%) Total Size: 1.38 MB
ℹ️ View Unchanged
|
ZebulanStanphill
force-pushed
the
update/document-sidebar-panels
branch
4 times, most recently
from
e5e583e
to
bc9b783
Compare
6 tasks
ZebulanStanphill
changed the title
ZebulanStanphill
changed the title
ZebulanStanphill
force-pushed
the
update/document-sidebar-panels
branch
2 times, most recently
from
cbf06fa
to
f1c0afd
Compare
ZebulanStanphill
changed the base branch from
master
to
update/polish-editor-post-format-component
ZebulanStanphill
force-pushed
the
update/polish-editor-post-format-component
branch
from
831ddf7
to
43fb27f
Compare
ZebulanStanphill
force-pushed
the
update/document-sidebar-panels
branch
7 times, most recently
from
42c586f
to
e680392
Compare
ZebulanStanphill
force-pushed
the
update/polish-editor-post-format-component
branch
from
43fb27f
to
02a24e9
Compare
ZebulanStanphill
force-pushed
the
update/document-sidebar-panels
branch
5 times, most recently
from
89ac09c
to
78a47fa
Compare
8 tasks
I'd agree the text length issue is not a problem because it's addressed in #25170. The Safari / VoiceOver buggy behavior discussed there appears to be a VoiceOver bug. The information is available anyways, it's just not announced automatically. @shaunandrews some design magic to "find a better home" for sticky, pending, author, and trash would be great. As said above, I'm not sure they belong to "Status and Visibility" even in the current implementation. |
6 tasks
|
I agree with @shaunandrews that there's no need to repeat the label here:
We can do without it and the overall control is still obvious:
Note: The above mockup is pending the feedback provided on #25170 (comment). I also agree that the stuff inside the 'General' panel feels thrown in without much thought, but you can also argue that not much is changing now because previously these were all under 'Status & visibility' all the same. We should change the panel's label from 'General' to 'Status', and this way we keep at least a bit of the previous organizaton. From "Status & Visibility" to "Status" and "Visibility". For clarity, I'd only move the author's select component to the next line below. This should also help with space with long names and translations:
How does all of this feel to you, @ZebulanStanphill? |
ZebulanStanphill
force-pushed
the
update/polish-editor-post-format-component
branch
3 times, most recently
from
ab71abb
to
0ce47ba
Compare
ZebulanStanphill
force-pushed
the
update/document-sidebar-panels
branch
from
ef62f2f
to
23f43b9
Compare
ZebulanStanphill
force-pushed
the
update/polish-editor-post-format-component
branch
from
0ce47ba
to
021ea6c
Compare
ZebulanStanphill
force-pushed
the
update/document-sidebar-panels
branch
from
23f43b9
to
85137a8
Compare
|
@enriquesanchez The author field is already displayed like that? As for the other stuff, I've gone ahead and implemented them. Here's how it looks now:
|
ZebulanStanphill
removed
the
Needs Accessibility Feedback
ZebulanStanphill
force-pushed
the
update/polish-editor-post-format-component
branch
from
021ea6c
to
2f4de98
Compare
ZebulanStanphill
force-pushed
the
update/document-sidebar-panels
branch
from
85137a8
to
e8e8c95
Compare
|
@ZebulanStanphill Looks great!
|
ZebulanStanphill
force-pushed
the
update/polish-editor-post-format-component
branch
from
2f4de98
to
589ff78
Compare
ZebulanStanphill
force-pushed
the
update/polish-editor-post-format-component
branch
from
589ff78
to
7128baa
Compare
ZebulanStanphill
force-pushed
the
update/document-sidebar-panels
branch
from
e8e8c95
to
9ba2295
Compare
ZebulanStanphill
force-pushed
the
update/polish-editor-post-format-component
branch
from
7128baa
to
cb172ac
Compare
ZebulanStanphill
force-pushed
the
update/document-sidebar-panels
branch
from
9ba2295
to
c7b538b
Compare
ZebulanStanphill
force-pushed
the
update/polish-editor-post-format-component
branch
from
cb172ac
to
1024849
Compare
ZebulanStanphill
force-pushed
the
update/document-sidebar-panels
branch
from
c7b538b
to
83c1b21
Compare
ZebulanStanphill
force-pushed
the
update/polish-editor-post-format-component
branch
from
1024849
to
8aa02d3
Compare
|
The "Status & visibility" UI has taken a different direction, and though much of the accessibility issues still remain, I no longer think the design in this PR is the best way to tackle them. I think something more like the mockups shown here is the way to go, albeit with some markup magic to make the function of the buttons clearer to screen readers. These buttons are essentially virtual For these reasons, as well as a general lack of spare time on my part, I'm closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Partially addresses #470. This PR splits the "Status & visibility" panel into multiple smaller panels, making things more organized and more accessible. It's not perfect, but it's better than what we currently have. It's also brings consistency with the pre-publish checks.
How has this been tested?
I tested to make sure the controls all still work, and the Post Format panel is hidden when post formats are not supported.
Screenshots
(If the text seems to be missing some boldness, that's just due to my device's default font lacking enough font weight variations.)
Checklist: