Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add global styles sidebar at edit site screen #24250

Merged
merged 84 commits into from
Sep 8, 2020
Merged

Add global styles sidebar at edit site screen #24250

merged 84 commits into from
Sep 8, 2020
+758 −175

Commits on Sep 8, 2020

  1. Typography panel: add line-height for the blocks that support it

    @oandregal
    oandregal committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    4c50a5f View commit details
    Browse the repository at this point in the history

  2. Show user data in controls

    @oandregal
    oandregal committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    c3d26b1 View commit details
    Browse the repository at this point in the history

  3. Extract to own files

    @oandregal
    oandregal committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    54c6116 View commit details
    Browse the repository at this point in the history

  4. Extract getters & setters to provider

    @oandregal
    oandregal committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    6ae71b6 View commit details
    Browse the repository at this point in the history

  5. Edit entities when user interacts with controls

    @oandregal
    oandregal committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    4e96c1c View commit details
    Browse the repository at this point in the history

  6. Pass the embedded stylesheet handle to the client

    @oandregal
    oandregal committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    495be14 View commit details
    Browse the repository at this point in the history

  7. Save proper value for font-size

    @oandregal
    oandregal committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    0d88467 View commit details
    Browse the repository at this point in the history

  8. Use edited data to feed controls & no overwrite existing data

    @oandregal
    oandregal committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    6be29f1 View commit details
    Browse the repository at this point in the history

  9. Do not overwrite existing data from other styles

    @oandregal
    oandregal committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    0b952d7 View commit details
    Browse the repository at this point in the history

  10. Remove passing down handle as styles are processed via settings, not … 

    …stylesheet
    @oandregal
    oandregal committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    00c6126 View commit details
    Browse the repository at this point in the history

  11. Add effect hook to update styles

    @oandregal
    oandregal committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    25cfb3a View commit details
    Browse the repository at this point in the history

  12. Update stylesheet from user data

    @oandregal
    oandregal committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    ac89dcf View commit details
    Browse the repository at this point in the history

  13. Account for blocks that do not define a particular property

    @oandregal
    oandregal committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    c0ef0b3 View commit details
    Browse the repository at this point in the history

  14. Remove line breaks from stylesheet

    @oandregal
    oandregal committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    4c1e497 View commit details
    Browse the repository at this point in the history

  15. Add skeleton for color panel

    @oandregal
    oandregal committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    62ded6b View commit details
    Browse the repository at this point in the history

  16. Remove base styles as we only need to generate user styles

    @oandregal
    oandregal committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    ac655f5 View commit details
    Browse the repository at this point in the history

  17. Add colors

    @oandregal
    oandregal committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    0c4e8dc View commit details
    Browse the repository at this point in the history

  18. Work only with published CPT for user data

    @oandregal
    oandregal committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    31a8b1a View commit details
    Browse the repository at this point in the history

  19. Fix phpdocs

    @oandregal
    oandregal committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    f0b0293 View commit details
    Browse the repository at this point in the history

  20. Fix color names

    @oandregal
    oandregal committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    56850d5 View commit details
    Browse the repository at this point in the history

  21. Compact API: expose only getProperty / setProperty

    @oandregal
    oandregal committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    f69f437 View commit details
    Browse the repository at this point in the history

  22. Create panels per block

    @oandregal
    oandregal committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    3c9b3a6 View commit details
    Browse the repository at this point in the history

  23. Do not render heading block yet

    @oandregal
    oandregal committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    7bc6cb7 View commit details
    Browse the repository at this point in the history

  24. Fix selector for core blocks

    @oandregal
    oandregal committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    3581e1f View commit details
    Browse the repository at this point in the history

  25. PoC for global context

    @oandregal
    oandregal committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    7b30c5d View commit details
    Browse the repository at this point in the history

  26. Add typography panel

    @oandregal
    oandregal committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    a57df47 View commit details
    Browse the repository at this point in the history

  27. Use typography icon

    @oandregal
    oandregal committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    43fae0b View commit details
    Browse the repository at this point in the history

  28. Load global styles settings only in edit-site

    @oandregal
    oandregal committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    a2c0860 View commit details
    Browse the repository at this point in the history

  29. Generate stylesheet in the client - step 1

    @oandregal
    oandregal committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    c045d88 View commit details
    Browse the repository at this point in the history

  30. Generate stylesheet in the client - step 2

    @oandregal
    oandregal committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    554a857 View commit details
    Browse the repository at this point in the history

  31. Add stylesheet for link color

    @oandregal
    oandregal committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    d7392b5 View commit details
    Browse the repository at this point in the history

  32. Make order as front

    @oandregal
    oandregal committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    3ad9f9b View commit details
    Browse the repository at this point in the history

  33. Generate stylesheet in the client - step 3

    @oandregal
    oandregal committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    8a4667b View commit details
    Browse the repository at this point in the history

  34. Disable font-size for the global level

    @oandregal
    oandregal committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    91ede60 View commit details
    Browse the repository at this point in the history

  35. Make sure font-size is removed from the entity

    @oandregal
    oandregal committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    db6c9dc View commit details
    Browse the repository at this point in the history

  36. Enable back font-size

    @oandregal
    oandregal committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    072e5f4 View commit details
    Browse the repository at this point in the history

  37. Fix rebase

    @oandregal
    oandregal committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    7cd35cd View commit details
    Browse the repository at this point in the history

  38. format-js

    @oandregal
    oandregal committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    f55fe3e View commit details
    Browse the repository at this point in the history

  39. Show all blocks, including core/heading/*

    @oandregal
    oandregal committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    7d4389d View commit details
    Browse the repository at this point in the history

  40. Show title per context

    @oandregal
    oandregal committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    e10e375 View commit details
    Browse the repository at this point in the history

  41. Destructure selector

    @oandregal
    oandregal committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    02af322 View commit details
    Browse the repository at this point in the history

  42. Refactor to reduce the amount of data and extract global to constant

    @oandregal
    oandregal committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    33f20d4 View commit details
    Browse the repository at this point in the history

  43. Inline function

    @oandregal
    oandregal committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    584c145 View commit details
    Browse the repository at this point in the history

  44. Simplify code

    @oandregal
    oandregal committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    a5bb681 View commit details
    Browse the repository at this point in the history

  45. Simplify code for renderer

    @oandregal
    oandregal committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    279eadc View commit details
    Browse the repository at this point in the history

  46. Add prettier suggestion

    @oandregal
    oandregal committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    03fad42 View commit details
    Browse the repository at this point in the history

  47. Fix rebase

    @oandregal
    oandregal committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    cd55f33 View commit details
    Browse the repository at this point in the history

  48. Fix warnings

    @oandregal
    oandregal committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    cdda0e2 View commit details
    Browse the repository at this point in the history

  49. Add comment about not using cloneDeep

    @oandregal
    oandregal committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    8ec4ca0 View commit details
    Browse the repository at this point in the history

  50. Fix comment

    @oandregal
    oandregal committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    f16b7ac View commit details
    Browse the repository at this point in the history

  51. Compact code

    @oandregal
    oandregal committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    f73e2bb View commit details
    Browse the repository at this point in the history

  52. Make linter happy

    @oandregal
    oandregal committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    3ceeac7 View commit details
    Browse the repository at this point in the history

  53. Make provider units agnostic 

    Note that, at the moment, font-size is serialized to px [1].
We follow that convention at global styles level.

[1] see packages/element/src/serialize.js#getNormalStylePropertyValue
    @oandregal
    oandregal committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    ac1dadd View commit details
    Browse the repository at this point in the history

  54. Use EntityProvider to get/set the CPT

    @oandregal
    oandregal committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    9d7abcf View commit details
    Browse the repository at this point in the history

  55. Only process request if theme has theme.json support

    @oandregal
    oandregal committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    c97540c View commit details
    Browse the repository at this point in the history

  56. Do not try to generate stylesheet if we have no data

    @oandregal
    oandregal committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    8025a07 View commit details
    Browse the repository at this point in the history

  57. Do not show global styles sidebar if no proper data

    @oandregal
    oandregal committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    6a347b3 View commit details
    Browse the repository at this point in the history

  58. Extract TypographyPanel

    @oandregal
    oandregal committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    ffce3e6 View commit details
    Browse the repository at this point in the history

  59. Prettier changes

    @oandregal
    oandregal committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    2819d1b View commit details
    Browse the repository at this point in the history

  60. Extract ColorPanel

    @oandregal
    oandregal committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    48ab467 View commit details
    Browse the repository at this point in the history

  61. Use ColorPanel in BlockPanel

    @oandregal
    oandregal committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    36f55a3 View commit details
    Browse the repository at this point in the history

  62. Get rid of GlobalPanel & BlockPanel in favor of inlining the style co… 

    …mponents
    @oandregal
    oandregal committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    43d4dab View commit details
    Browse the repository at this point in the history

  63. Better variable name and comment

    @oandregal
    oandregal committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    5d38eb0 View commit details
    Browse the repository at this point in the history

  64. Reformat to make less diff changes

    @oandregal
    oandregal committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    6a180f1 View commit details
    Browse the repository at this point in the history

  65. Fix variable name

    @oandregal
    oandregal committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    4f56221 View commit details
    Browse the repository at this point in the history

  66. Use PanelColorGradientSettings

    @oandregal
    oandregal committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    80b38a7 View commit details
    Browse the repository at this point in the history

  67. Add support for gradient colors

    @oandregal
    oandregal committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    510181f View commit details
    Browse the repository at this point in the history

  68. Simplify setProperty object merging

    @oandregal
    oandregal committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    602920f View commit details
    Browse the repository at this point in the history

  69. Migrate setProperty to use path

    @oandregal
    oandregal committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    09dc3d9 View commit details
    Browse the repository at this point in the history

  70. Migrate getProperty to use path

    @oandregal
    oandregal committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    c511af2 View commit details
    Browse the repository at this point in the history

  71. Pass object to setProperty to allow updating multiple entries at once

    @oandregal
    oandregal committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    30b8bcf View commit details
    Browse the repository at this point in the history

  72. prettify

    @oandregal
    oandregal committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    027db4d View commit details
    Browse the repository at this point in the history

  73. Make gradients work

    @oandregal
    oandregal committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    dae9269 View commit details
    Browse the repository at this point in the history

  74. Allow background without gradient

    @oandregal
    oandregal committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    6dfc7e5 View commit details
    Browse the repository at this point in the history

  75. Revert adding wrong check 

    Since #22520 was merged
on May we've been enqueuing the presets as CSS variables
whether or not the theme had support for theme.json
as a way to speed up themes using them and get feedback.

There are enough checks in place that this is inocuous.
    @oandregal
    oandregal committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    422a359 View commit details
    Browse the repository at this point in the history

  76. Clarify gutenberg_experimental_global_styles_settings

    @oandregal
    oandregal committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    43a6f12 View commit details
    Browse the repository at this point in the history

  77. Remove incorrect comment

    @oandregal
    oandregal committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    63dc5f1 View commit details
    Browse the repository at this point in the history

  78. Refactor GlobalStylesProvider

    @oandregal
    oandregal committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    16ed391 View commit details
    Browse the repository at this point in the history

  79. Fix function arguments

    @oandregal
    oandregal committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    fbbac37 View commit details
    Browse the repository at this point in the history

  80. Fix style effect

    @oandregal
    oandregal committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    3491e92 View commit details
    Browse the repository at this point in the history

  81. Disable custom gradients

    @oandregal
    oandregal committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    0248802 View commit details
    Browse the repository at this point in the history

  82. Prettify

    @oandregal
    oandregal committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    b90617e View commit details
    Browse the repository at this point in the history

  83. Update close button label

    @oandregal
    oandregal committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    76a68c3 View commit details
    Browse the repository at this point in the history

  84. gutenberg_is_edit_site_page is only load when the experiment is active

    @oandregal
    oandregal committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    20fcaaa View commit details
    Browse the repository at this point in the history