External image upload: fix uncaught error #24334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +3 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
6 tasks
ajlende
approved these changes
Jul 12, 2021
There was a problem hiding this comment.
Tested after rebasing with trunk to make sure things were up-to-date.
Silently failing this seems fine to me. The uncaught error is gone.
Uncaught (in promise) TypeError: Failed to fetch
Uncaught (in promise) TypeError: NetworkError when attempting to fetch resource.
The CORS log still shows which I also think is fine.
Access to fetch at 'https://localhost:8081/image.jpg' from origin 'https://wp.local' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource. If an opaque response serves your needs, set the request's mode to 'no-cors' to fetch the resource with CORS disabled.
Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at https://localhost:8081/image.jpg. (Reason: CORS header ‘Access-Control-Allow-Origin’ missing).
ellatrix
force-pushed
the
fix/image-uncaught
branch
from
5cfd4e9
to
ea8447d
Compare
|
Thanks! |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an "uncaught" type error by nooping it. Not sure what else to do here.
How has this been tested?
Screenshots
Types of changes
Checklist: