[RNMobile] E2E Android - Use swipe gesture to scroll inserter menu #24338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dratwas
changed the title
|
Size Change: 0 B Total Size: 1.16 MB ℹ️ View Unchanged
|
2 tasks
|
We just cut the release branches for 1.34.0 and I'm assuming we'll want this fix in that branch as well so we can run the automated tests on the release. Let's make sure this fix gets added to those branches as well. cc: @ceyhun , @cameronvoell |
dratwas
added
the
Mobile App - i.e. Android or iOS
ceyhun
approved these changes
Aug 4, 2020
ceyhun
pushed a commit
that referenced
this pull request
Aug 4, 2020
ceyhun
added a commit
to wordpress-mobile/gutenberg-mobile
that referenced
this pull request
Aug 4, 2020
Cherry-picked WordPress/gutenberg#24338
5 tasks
cameronvoell
added a commit
that referenced
this pull request
Aug 11, 2020
* Release script: Update react-native-editor version to 1.34.0 * [RNMobile] E2E Android - Use swipe gesture to scroll inserter menu (#24338) * Set autosaveInterval to 1 on mobile (#24353) * Revert "[RNMobile] Fix jumping toolbar (#23684)" (#24388) This reverts commit d86cd5f. * Turn off autosave interval for mobile (#24415) * [RNMobile] Merge release 1.33.1 to master (#24448) * Release script: Update react-native-editor version to 1.33.0 * Update release notes. * Update version numbers for packages. * Revert "Reduce spacing between label and slider control (#23580)" (#24109) This reverts commit 2a67de0. * Release script: Update react-native-* versions to 1.33.1 * Release script: Update with changes from 'npm run core preios' * Allow @ char in posts in mobile editor (#24428) This fixes a bug with the @-mention feature on mobile that made entering the standalone @ character difficult because of the @-mention UI getting in the way. The fix here is to allow the @ character to be intercepted without being consumed by the @ key event logic. * Remove duplicate entry from changelog Co-authored-by: Sergio Estevao <sergioestevao@gmail.com> Co-authored-by: Antonis Lilis <antonis.lilis@gmail.com> Co-authored-by: Ceyhun Ozugur <ceyhunozugur@gmail.com> Co-authored-by: Paul Von Schrottky <paul.von.schrottky@automattic.com> * Update version numbers * Ran pod install to update podfile.lock Co-authored-by: Drapich Piotr <drapich.piotr@gmail.com> Co-authored-by: Adam Zielinski <adam@adamziel.com> Co-authored-by: Chip <chip.snyder3@gmail.com> Co-authored-by: Cameron Voell <cameronvoell@gmail.com> Co-authored-by: Sergio Estevao <sergioestevao@gmail.com> Co-authored-by: Antonis Lilis <antonis.lilis@gmail.com> Co-authored-by: Paul Von Schrottky <paul.von.schrottky@automattic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Gutenberg-mobile PR wordpress-mobile/gutenberg-mobile#2527
Fixes Failing CI e2e test on
gutenberg-mobilerepo. Android e2e tests started failing after removing the scroll view from the inserter menu. I couldn't reproduce it on my side but I could fix that by using swipe gesture instead of sending the keycode 20 (arrow down).I created the same Simulator as on Sauce Labs, used the same version of Appium and tests were passing on my side. I also tried to send locally keyevent by
adb shell input keyevent 20and that also works. However, I used the mechanism from here https://github.com/WordPress/gutenberg/pull/24338/files#diff-34060c7868e5c5d05b0a7f37b80fd440R453 that simulates the swipe gesture and tests pass.How has this been tested?
Types of changes
Use swipe gestures in e2e tests to scroll the inserter menu.
Checklist: