-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RNMobile] Refine spacing of Back button on ios #24350
Conversation
@iamthomasbishop I refined spacings, however, if you can provide better chevron svg icon which we can use, please let me know! |
Size Change: -450 B (0%) Total Size: 1.15 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from the code perspective 👍
@lukewalczak I added a new iOS back icon (
Altogether, it should look like this: Thank you! |
@lukewalczak So close to exact, I only have 1 more tiny request -- can we remove 3px of margin on the left side of the button? Example: Thank you for your patience! 😆 |
@lukewalczak I think we have a regression on the spacing for the back button, as shown below. Would you mind taking a look at this? |
@iamthomasbishop thanks for reporting that, I will check the root of regression and fix it! |
Fixes: wordpress-mobile/gutenberg-mobile#2528
Description
Refine spacing of back button on ios
How has this been tested?
Screenshots
Types of changes
Adjust back button paddings
Checklist: