Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RNMobile] Refine spacing of Back button on ios #24350

Merged
merged 4 commits into from
Aug 7, 2020

Conversation

lukewalczak
Copy link
Member

Fixes: wordpress-mobile/gutenberg-mobile#2528

Description

Refine spacing of back button on ios

How has this been tested?

Screenshots

before after
Screenshot 2020-08-04 at 11 32 15 Screenshot 2020-08-04 at 11 32 22

Types of changes

Adjust back button paddings

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@lukewalczak
Copy link
Member Author

@iamthomasbishop I refined spacings, however, if you can provide better chevron svg icon which we can use, please let me know!

@github-actions
Copy link

github-actions bot commented Aug 4, 2020

Size Change: -450 B (0%)

Total Size: 1.15 MB

Filename Size Change
build/block-editor/index.js 125 kB -4 B (0%)
build/block-editor/style-rtl.css 10.6 kB -180 B (1%)
build/block-editor/style.css 10.6 kB -178 B (1%)
build/block-library/index.js 132 kB -54 B (0%)
build/edit-post/style-rtl.css 5.59 kB -17 B (0%)
build/edit-post/style.css 5.59 kB -17 B (0%)
ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.14 kB 0 B
build/annotations/index.js 3.67 kB 0 B
build/api-fetch/index.js 3.44 kB 0 B
build/autop/index.js 2.82 kB 0 B
build/blob/index.js 620 B 0 B
build/block-directory/index.js 7.97 kB 0 B
build/block-directory/style-rtl.css 953 B 0 B
build/block-directory/style.css 952 B 0 B
build/block-library/editor-rtl.css 7.59 kB 0 B
build/block-library/editor.css 7.59 kB 0 B
build/block-library/style-rtl.css 7.76 kB 0 B
build/block-library/style.css 7.77 kB 0 B
build/block-library/theme-rtl.css 729 B 0 B
build/block-library/theme.css 730 B 0 B
build/block-serialization-default-parser/index.js 1.88 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/blocks/index.js 48.3 kB 0 B
build/components/index.js 200 kB 0 B
build/components/style-rtl.css 15.7 kB 0 B
build/components/style.css 15.7 kB 0 B
build/compose/index.js 9.68 kB 0 B
build/core-data/index.js 11.8 kB 0 B
build/data-controls/index.js 1.29 kB 0 B
build/data/index.js 8.45 kB 0 B
build/date/index.js 5.38 kB 0 B
build/deprecated/index.js 772 B 0 B
build/dom-ready/index.js 568 B 0 B
build/dom/index.js 3.23 kB 0 B
build/edit-navigation/index.js 10.9 kB 0 B
build/edit-navigation/style-rtl.css 1.08 kB 0 B
build/edit-navigation/style.css 1.08 kB 0 B
build/edit-post/index.js 304 kB 0 B
build/edit-site/index.js 17 kB 0 B
build/edit-site/style-rtl.css 3.06 kB 0 B
build/edit-site/style.css 3.06 kB 0 B
build/edit-widgets/index.js 9.38 kB 0 B
build/edit-widgets/style-rtl.css 2.45 kB 0 B
build/edit-widgets/style.css 2.45 kB 0 B
build/editor/editor-styles-rtl.css 537 B 0 B
build/editor/editor-styles.css 539 B 0 B
build/editor/index.js 45.3 kB 0 B
build/editor/style-rtl.css 3.8 kB 0 B
build/editor/style.css 3.79 kB 0 B
build/element/index.js 4.65 kB 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/index.js 7.72 kB 0 B
build/format-library/style-rtl.css 547 B 0 B
build/format-library/style.css 548 B 0 B
build/hooks/index.js 2.13 kB 0 B
build/html-entities/index.js 621 B 0 B
build/i18n/index.js 3.56 kB 0 B
build/is-shallow-equal/index.js 711 B 0 B
build/keyboard-shortcuts/index.js 2.52 kB 0 B
build/keycodes/index.js 1.94 kB 0 B
build/list-reusable-blocks/index.js 3.11 kB 0 B
build/list-reusable-blocks/style-rtl.css 476 B 0 B
build/list-reusable-blocks/style.css 476 B 0 B
build/media-utils/index.js 5.33 kB 0 B
build/notices/index.js 1.79 kB 0 B
build/nux/index.js 3.4 kB 0 B
build/nux/style-rtl.css 671 B 0 B
build/nux/style.css 668 B 0 B
build/plugins/index.js 2.56 kB 0 B
build/primitives/index.js 1.41 kB 0 B
build/priority-queue/index.js 789 B 0 B
build/redux-routine/index.js 2.85 kB 0 B
build/rich-text/index.js 13.9 kB 0 B
build/server-side-render/index.js 2.71 kB 0 B
build/shortcode/index.js 1.7 kB 0 B
build/token-list/index.js 1.27 kB 0 B
build/url/index.js 4.06 kB 0 B
build/viewport/index.js 1.85 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.17 kB 0 B

compressed-size-action

Copy link
Contributor

@dratwas dratwas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from the code perspective 👍

@iamthomasbishop
Copy link

@lukewalczak I added a new iOS back icon (icon-ios-back-chevron) and also the back button unit to the design docs. A couple of things to note:

  • The new icon is 12x21
  • With that change, there should be 5px of spacing between icon and label

Altogether, it should look like this:

Thank you!

@lukewalczak
Copy link
Member Author

UPDATES

I've added a new icon called chevronBackIOS for navigation header in the bottom sheets

light dark
Screenshot 2020-08-06 at 11 03 35 Screenshot 2020-08-06 at 11 03 14

@iamthomasbishop
Copy link

@lukewalczak So close to exact, I only have 1 more tiny request -- can we remove 3px of margin on the left side of the button? Example:

Thank you for your patience! 😆

@lukewalczak
Copy link
Member Author

UPDATES

Reduce the spacing - confirmed on slack with Thomas, and it's correct!

Screenshot 2020-08-06 at 22 11 33

@lukewalczak lukewalczak merged commit cb0037d into master Aug 7, 2020
@lukewalczak lukewalczak deleted the rnmobile/refine-back-button branch August 7, 2020 11:14
@github-actions github-actions bot added this to the Gutenberg 8.8 milestone Aug 7, 2020
@iamthomasbishop
Copy link

@lukewalczak I think we have a regression on the spacing for the back button, as shown below. Would you mind taking a look at this?

@lukewalczak
Copy link
Member Author

@iamthomasbishop thanks for reporting that, I will check the root of regression and fix it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[iOS] Refine spacing of "< Back" button
3 participants