-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RNMobile] Renamed UnsupportedFooterControl to FooterMessageControl #24399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukewalczak
requested review from
ajitbohra,
chrisvanpatten and
youknowriad
as code owners
August 6, 2020 09:30
6 tasks
dratwas
reviewed
Aug 6, 2020
packages/components/src/mobile/bottom-sheet/footer-message-cell.js
Outdated
Show resolved
Hide resolved
Size Change: 0 B Total Size: 1.15 MB ℹ️ View Unchanged
|
lukewalczak
force-pushed
the
rnmobile/message-control
branch
from
August 7, 2020 11:52
7f0ab57
to
2d04c27
Compare
lukewalczak
force-pushed
the
rnmobile/message-control
branch
from
August 7, 2020 12:18
2d04c27
to
97a790f
Compare
lukewalczak
force-pushed
the
rnmobile/message-control
branch
from
August 7, 2020 12:50
3b2481a
to
96188ea
Compare
dratwas
approved these changes
Aug 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've decided to rename
UnsupportedFooterControl
toFooterMessageControl
since that component is rather used to present a different kind of message withinBottomSheet
.Change the name of
UnsupportedFooterControl
How has this been tested?
Briefly describe the link to help screen reader user
Screenshots
Types of changes
Enhancement
Checklist: