-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RNMobile] another approach to fix jumping toolbar #24414
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukewalczak
added
the
Mobile App - i.e. Android or iOS
Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
label
Aug 6, 2020
Size Change: +1.3 kB (0%) Total Size: 1.16 MB
ℹ️ View Unchanged
|
chipsnyder
approved these changes
Aug 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and it's working as described for me. Thanks for the quick fix @lukewalczak!
dratwas
reviewed
Aug 6, 2020
packages/components/src/mobile/keyboard-avoiding-view/index.ios.js
Outdated
Show resolved
Hide resolved
dratwas
reviewed
Aug 6, 2020
dratwas
reviewed
Aug 11, 2020
packages/components/src/mobile/keyboard-avoiding-view/index.ios.js
Outdated
Show resolved
Hide resolved
dratwas
approved these changes
Aug 12, 2020
6 tasks
lukewalczak
added a commit
that referenced
this pull request
Aug 14, 2020
This reverts commit 6604d96.
pinarol
pushed a commit
that referenced
this pull request
Aug 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Mobile App - i.e. Android or iOS
Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix jumping toolbar after closing the
LinkSettings
when Button/Paragraph is focusedFixes: wordpress-mobile/gutenberg-mobile#2301
How has this been tested?
TEST CASE 1
5. Expect: toolbar mustn't jump
TEST CASE 2
Site page
4. Expect to see layout template buttons
8. Expect: toolbar mustn't jump
TEST CASE 3
...
button in the right cornerSwitch to HTML mode
6. Expect to be able to scroll the content
7. Focus one of the paragraphs
8. Expect to be able to edit the content and scroll it
Test as well Buttons-1-2-3
Screenshots
Types of changes
Checklist: