Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RNMobile] another approach to fix jumping toolbar #24414

Merged
merged 5 commits into from
Aug 13, 2020

Conversation

lukewalczak
Copy link
Member

Description

Fix jumping toolbar after closing the LinkSettings when Button/Paragraph is focused

Fixes: wordpress-mobile/gutenberg-mobile#2301

How has this been tested?

TEST CASE 1

  1. Add a Button
  2. Click on Button block settings
  3. Focus on URL field
  4. Close the Bottom sheet by tapping outside of it
    5. Expect: toolbar mustn't jump

TEST CASE 2

  1. Open mobile app
  2. Press FAB
  3. Choose Site page
    4. Expect to see layout template buttons
  4. Press paragraph
  5. Press link icon
  6. Close bottom sheet
    8. Expect: toolbar mustn't jump

TEST CASE 3

  1. Open mobile app
  2. Open new post/site
  3. Press ... button in the right corner
  4. Choose Switch to HTML mode
  5. Paste the HTML code
<!-- wp:paragraph -->
<p></p>
<!-- /wp:paragraph -->

<!-- wp:paragraph -->
<p></p>
<!-- /wp:paragraph -->

<!-- wp:paragraph -->
<p></p>
<!-- /wp:paragraph -->

<!-- wp:paragraph -->
<p></p>
<!-- /wp:paragraph -->

<!-- wp:paragraph -->
<p></p>
<!-- /wp:paragraph -->

<!-- wp:paragraph -->
<p></p>
<!-- /wp:paragraph -->

<!-- wp:paragraph -->
<p></p>
<!-- /wp:paragraph -->

<!-- wp:paragraph -->
<p></p>
<!-- /wp:paragraph -->

<!-- wp:paragraph -->
<p></p>
<!-- /wp:paragraph -->

<!-- wp:paragraph -->
<p></p>
<!-- /wp:paragraph -->

<!-- wp:paragraph -->
<p></p>
<!-- /wp:paragraph -->

<!-- wp:paragraph -->
<p></p>
<!-- /wp:paragraph -->

<!-- wp:paragraph -->
<p></p>
<!-- /wp:paragraph -->

6. Expect to be able to scroll the content
7. Focus one of the paragraphs
8. Expect to be able to edit the content and scroll it

Test as well Buttons-1-2-3

Screenshots

iphone 8 iphone 11
jump_toolbar_ok keyboard_iX_2

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@lukewalczak lukewalczak self-assigned this Aug 6, 2020
@lukewalczak lukewalczak added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Aug 6, 2020
@github-actions
Copy link

github-actions bot commented Aug 6, 2020

Size Change: +1.3 kB (0%)

Total Size: 1.16 MB

Filename Size Change
build/block-editor/index.js 125 kB +241 B (0%)
build/block-editor/style-rtl.css 10.6 kB -136 B (1%)
build/block-editor/style.css 10.6 kB -132 B (1%)
build/block-library/editor-rtl.css 8.36 kB +768 B (9%) 🔍
build/block-library/editor.css 8.36 kB +768 B (9%) 🔍
build/block-library/index.js 132 kB -192 B (0%)
build/block-library/style-rtl.css 7.49 kB -277 B (3%)
build/block-library/style.css 7.49 kB -278 B (3%)
build/blocks/index.js 48.4 kB +98 B (0%)
build/components/index.js 200 kB +72 B (0%)
build/components/style-rtl.css 15.7 kB +2 B (0%)
build/components/style.css 15.7 kB +2 B (0%)
build/edit-post/index.js 304 kB +273 B (0%)
build/edit-post/style-rtl.css 5.63 kB +24 B (0%)
build/edit-post/style.css 5.63 kB +23 B (0%)
build/editor/index.js 45.3 kB +40 B (0%)
build/element/index.js 4.65 kB +1 B
ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.14 kB 0 B
build/annotations/index.js 3.67 kB 0 B
build/api-fetch/index.js 3.44 kB 0 B
build/autop/index.js 2.82 kB 0 B
build/blob/index.js 620 B 0 B
build/block-directory/index.js 7.97 kB 0 B
build/block-directory/style-rtl.css 953 B 0 B
build/block-directory/style.css 952 B 0 B
build/block-library/theme-rtl.css 729 B 0 B
build/block-library/theme.css 730 B 0 B
build/block-serialization-default-parser/index.js 1.88 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/compose/index.js 9.68 kB 0 B
build/core-data/index.js 11.8 kB 0 B
build/data-controls/index.js 1.29 kB 0 B
build/data/index.js 8.45 kB 0 B
build/date/index.js 5.38 kB 0 B
build/deprecated/index.js 772 B 0 B
build/dom-ready/index.js 568 B 0 B
build/dom/index.js 3.23 kB 0 B
build/edit-navigation/index.js 10.9 kB 0 B
build/edit-navigation/style-rtl.css 1.08 kB 0 B
build/edit-navigation/style.css 1.08 kB 0 B
build/edit-site/index.js 17 kB 0 B
build/edit-site/style-rtl.css 3.06 kB 0 B
build/edit-site/style.css 3.06 kB 0 B
build/edit-widgets/index.js 9.38 kB 0 B
build/edit-widgets/style-rtl.css 2.45 kB 0 B
build/edit-widgets/style.css 2.45 kB 0 B
build/editor/editor-styles-rtl.css 537 B 0 B
build/editor/editor-styles.css 539 B 0 B
build/editor/style-rtl.css 3.8 kB 0 B
build/editor/style.css 3.79 kB 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/index.js 7.72 kB 0 B
build/format-library/style-rtl.css 547 B 0 B
build/format-library/style.css 548 B 0 B
build/hooks/index.js 2.13 kB 0 B
build/html-entities/index.js 621 B 0 B
build/i18n/index.js 3.56 kB 0 B
build/is-shallow-equal/index.js 711 B 0 B
build/keyboard-shortcuts/index.js 2.52 kB 0 B
build/keycodes/index.js 1.94 kB 0 B
build/list-reusable-blocks/index.js 3.11 kB 0 B
build/list-reusable-blocks/style-rtl.css 476 B 0 B
build/list-reusable-blocks/style.css 476 B 0 B
build/media-utils/index.js 5.33 kB 0 B
build/notices/index.js 1.79 kB 0 B
build/nux/index.js 3.4 kB 0 B
build/nux/style-rtl.css 671 B 0 B
build/nux/style.css 668 B 0 B
build/plugins/index.js 2.56 kB 0 B
build/primitives/index.js 1.41 kB 0 B
build/priority-queue/index.js 789 B 0 B
build/redux-routine/index.js 2.85 kB 0 B
build/rich-text/index.js 13.9 kB 0 B
build/server-side-render/index.js 2.71 kB 0 B
build/shortcode/index.js 1.7 kB 0 B
build/token-list/index.js 1.27 kB 0 B
build/url/index.js 4.06 kB 0 B
build/viewport/index.js 1.85 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.17 kB 0 B

compressed-size-action

Copy link
Contributor

@chipsnyder chipsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it's working as described for me. Thanks for the quick fix @lukewalczak!

@lukewalczak lukewalczak merged commit 6604d96 into master Aug 13, 2020
@lukewalczak lukewalczak deleted the rnmobile/fix-jumping-toolbar-vol-2 branch August 13, 2020 09:36
@github-actions github-actions bot added this to the Gutenberg 8.8 milestone Aug 13, 2020
lukewalczak added a commit that referenced this pull request Aug 14, 2020
pinarol pushed a commit that referenced this pull request Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Button: Toolbar goes up and down for a split second when dismissing settings
3 participants