Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try a more compact save state indicator #2445

Merged
merged 3 commits into from
Aug 18, 2017
Merged

Conversation

jasmussen
Copy link
Contributor

@jasmussen jasmussen commented Aug 17, 2017

This PR does three things:

  1. It makes the "Save Draft" label just say "Save" on mobile
  2. It tightens the space around the editor mode switch, while keeping the hit area the same
  3. It adds negative margin to the "Saved" dashicon so it visually aligns with the text

Screenshots:

screen shot 2017-08-17 at 10 18 00

screen shot 2017-08-17 at 10 18 07

screen shot 2017-08-17 at 10 18 39

saveindicator

@jasmussen jasmussen added the Mobile Web Viewport sizes for mobile and tablet devices label Aug 17, 2017
@jasmussen jasmussen self-assigned this Aug 17, 2017
@codecov
Copy link

codecov bot commented Aug 18, 2017

Codecov Report

Merging #2445 into master will increase coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2445      +/-   ##
==========================================
+ Coverage   26.51%   26.64%   +0.12%     
==========================================
  Files         158      158              
  Lines        4853     5074     +221     
  Branches      816      887      +71     
==========================================
+ Hits         1287     1352      +65     
- Misses       3013     3115     +102     
- Partials      553      607      +54
Impacted Files Coverage Δ
editor/header/saved-state/index.js 85.71% <ø> (ø) ⬆️
blocks/editable/index.js 9.57% <0%> (-1.31%) ⬇️
blocks/api/paste/normalise-blocks.js 95.74% <0%> (-0.26%) ⬇️
editor/sidebar/table-of-contents/item.js 0% <0%> (ø) ⬆️
blocks/api/paste/strip-attributes.js 100% <0%> (ø) ⬆️
editor/sidebar/table-of-contents/index.js 0% <0%> (ø) ⬆️
blocks/api/paste/strip-wrappers.js 100% <0%> (ø) ⬆️
blocks/api/paste/index.js 100% <0%> (ø) ⬆️
blocks/editable/format-toolbar/index.js 10% <0%> (+2.5%) ⬆️
editor/utils/url.js 66.66% <0%> (+66.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03bd015...cbbd5dd. Read the comment docs.

@jasmussen
Copy link
Contributor Author

Merging this. Let's consider separately exploring augmenting tests to account for viewport widths.

@jasmussen jasmussen merged commit d5f1b04 into master Aug 18, 2017
@jasmussen jasmussen deleted the try/compact-save-indicator branch August 18, 2017 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile Web Viewport sizes for mobile and tablet devices
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants