Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use internal libxml errors instead of @suppression #24677

Merged
merged 2 commits into from
Sep 1, 2020
Merged

Use internal libxml errors instead of @suppression #24677

merged 2 commits into from
Sep 1, 2020

Commits on Aug 20, 2020

  1. Use internal libxml errors instead of @suppression 

    Instead of using `@` to suppress errors during `DOMDocument::loadHTML`
use `libxml_use_internal_errors` to capture and suppress the errors
instead.

If there is a custom `set_error_handler` set for your installation it
will continue to receive warnings and html validation errors from this
`loadHTML` call. If the goal is to suppress these errors we should try
to capture and drop these without polluting customized error logs.
    @lsl
    lsl committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    95a6e96 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2020

  1. Typo elemetns != elements 

    -
    @lsl
    lsl authored Sep 1, 2020
    Configuration menu
    Copy the full SHA
    2560acb View commit details
    Browse the repository at this point in the history