-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[edit-widgets] Fix isSavingWidgetAreas selector #24788
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamziel
added
[Feature] Widgets Screen
The block-based screen that replaced widgets.php.
[Package] Edit Widgets
/packages/edit-widgets
labels
Aug 25, 2020
adamziel
requested review from
draganescu,
shaunandrews,
noisysocks and
tellthemachines
August 25, 2020 10:48
20 tasks
Size Change: +87 B (0%) Total Size: 1.16 MB
ℹ️ View Unchanged
|
draganescu
approved these changes
Aug 25, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works like a charm!
noisysocks
approved these changes
Aug 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] Widgets Screen
The block-based screen that replaced widgets.php.
[Package] Edit Widgets
/packages/edit-widgets
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As mentioned in #24290 (review), the widgets management screen should indicate progress when the Block Area screen's Update button is clicked.
It turns out the code was in there, but
isSavingWidgetAreas
selector wasn't working properly. This PR fixes that selector and improves the interaction with the button.Before
After
How has this been tested?
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: