-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Widgets: Remove experimental flag, enable for themes that have not opted out #24843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noisysocks
added
[Feature] Widgets Screen
The block-based screen that replaced widgets.php.
[Type] Feature
New feature to highlight in changelogs.
[Type] New API
New API to be used by plugin developers or package users.
labels
Aug 27, 2020
noisysocks
requested review from
ajitbohra,
ellatrix,
Soean,
spacedmonkey,
talldan,
TimothyBJacobs and
youknowriad
as code owners
August 27, 2020 05:07
noisysocks
added
the
[Status] Blocked
Used to indicate that a current effort isn't able to move forward
label
Aug 27, 2020
Size Change: -28 B (0%) Total Size: 1.17 MB
ℹ️ View Unchanged
|
6 tasks
Some features related to the new widgets screen should always be enabled regardless of whether or not the current them has support for widgets-block-editor: - The Legacy Widget block. This block is useful in other contexts such as FSE and posts. - The /__experimental/sidebars REST API.: This is a new API to be introduced to Core and is useful for third parties. - The /__experimental/widget-utils REST API.: This is a new API to be introduced to Core, is used by the Legacy Widget block, and is useful for third parties.
Allow the widgets block editor to be disabled using a filter. This is useful for plugins like Classic Editor.
youknowriad
force-pushed
the
remove/widgets-experiment-flag
branch
from
August 31, 2020 13:02
6f14507
to
3a60851
Compare
youknowriad
approved these changes
Aug 31, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like the blockers are now fixed.
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] Widgets Screen
The block-based screen that replaced widgets.php.
[Status] Blocked
Used to indicate that a current effort isn't able to move forward
[Type] Feature
New feature to highlight in changelogs.
[Type] New API
New API to be used by plugin developers or package users.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #24685
This PR:
remove_theme_support( 'widgets-block-editor' )
. (As in Replace the widgets screen experiment with a theme support #24087.)gutenberg_use_widgets_block_editor
filter that plugins (e.g. Support disabling widgets block editor classic-editor#137) can use to disable the new block-based screen./__experimental/sidebars
and/__experimental/widget-utils
REST APIs. This is a new API to be introduced to Core and is useful for third parties.All of the high priority items in #24530 must be resolved before merging this.