-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[edit-widgets] Make global inserter usable by passing correct rootClientId to it #24908
Conversation
Size Change: +80 B (0%) Total Size: 1.2 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense. I think the design is a separate issue as this was never refactored to use the "Panel" instead of the regular dropdown inserter.
One more change here would be inserting the widget to the most recently selected widget area instead of the first one as it happens ATM. |
1e2b9bf
to
7169f8b
Compare
I see this has been merged. |
I don't think it was merged just yet @paaljoachim |
Description
Global inserter is always inactive because it's receiving an incorrect
rootClientId
. That's related to the somewhat novel way in which blocks in the widgets editor are set up. This PR ensures the correct value is passed.Before
After
How has this been tested?
Screenshots
Types of changes
Non-breaking change
Checklist: