Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[edit-widgets] Make global inserter usable by passing correct rootClientId to it #24908

Merged
merged 2 commits into from
Sep 16, 2020

Conversation

adamziel
Copy link
Contributor

@adamziel adamziel commented Aug 28, 2020

Description

Global inserter is always inactive because it's receiving an incorrect rootClientId. That's related to the somewhat novel way in which blocks in the widgets editor are set up. This PR ensures the correct value is passed.

Before

Zrzut ekranu 2020-08-28 o 22 21 26

After

Zrzut ekranu 2020-08-28 o 22 21 31

How has this been tested?

  1. Go to the widgets editor.
  2. Confirm the global inserter works.

Screenshots

Types of changes

Non-breaking change

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@adamziel adamziel added [Feature] Widgets Screen The block-based screen that replaced widgets.php. [Package] Edit Widgets /packages/edit-widgets labels Aug 28, 2020
@adamziel adamziel changed the title Pass correct rootClientId to the inserter [edit-widgets] Pass correct rootClientId to the inserter Aug 28, 2020
@adamziel adamziel marked this pull request as draft August 28, 2020 20:28
@mapk
Copy link
Contributor

mapk commented Aug 28, 2020

It appears it's not positioned correctly. It should be flush to the left of the Editor/screen? Adjacent to the black admin menu. I also noticed the tabs are missing. Is that intentional?

Screen Shot 2020-08-28 at 1 27 48 PM

@github-actions
Copy link

github-actions bot commented Aug 28, 2020

Size Change: +80 B (0%)

Total Size: 1.2 MB

Filename Size Change
build/edit-widgets/index.js 12.3 kB +80 B (0%)
ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.14 kB 0 B
build/annotations/index.js 3.67 kB 0 B
build/api-fetch/index.js 3.41 kB 0 B
build/autop/index.js 2.82 kB 0 B
build/blob/index.js 620 B 0 B
build/block-directory/index.js 8.53 kB 0 B
build/block-directory/style-rtl.css 943 B 0 B
build/block-directory/style.css 942 B 0 B
build/block-editor/index.js 128 kB 0 B
build/block-editor/style-rtl.css 11 kB 0 B
build/block-editor/style.css 11 kB 0 B
build/block-library/editor-rtl.css 8.69 kB 0 B
build/block-library/editor.css 8.69 kB 0 B
build/block-library/index.js 139 kB 0 B
build/block-library/style-rtl.css 7.6 kB 0 B
build/block-library/style.css 7.59 kB 0 B
build/block-library/theme-rtl.css 741 B 0 B
build/block-library/theme.css 741 B 0 B
build/block-serialization-default-parser/index.js 1.88 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/blocks/index.js 47.8 kB 0 B
build/components/index.js 201 kB 0 B
build/components/style-rtl.css 15.5 kB 0 B
build/components/style.css 15.4 kB 0 B
build/compose/index.js 9.68 kB 0 B
build/core-data/index.js 12.2 kB 0 B
build/data-controls/index.js 1.28 kB 0 B
build/data/index.js 8.55 kB 0 B
build/date/index.js 31.9 kB 0 B
build/deprecated/index.js 772 B 0 B
build/dom-ready/index.js 568 B 0 B
build/dom/index.js 4.48 kB 0 B
build/edit-navigation/index.js 10.7 kB 0 B
build/edit-navigation/style-rtl.css 868 B 0 B
build/edit-navigation/style.css 871 B 0 B
build/edit-post/index.js 305 kB 0 B
build/edit-post/style-rtl.css 6.24 kB 0 B
build/edit-post/style.css 6.22 kB 0 B
build/edit-site/index.js 19 kB 0 B
build/edit-site/style-rtl.css 3.13 kB 0 B
build/edit-site/style.css 3.13 kB 0 B
build/edit-widgets/style-rtl.css 2.55 kB 0 B
build/edit-widgets/style.css 2.55 kB 0 B
build/editor/editor-styles-rtl.css 492 B 0 B
build/editor/editor-styles.css 493 B 0 B
build/editor/index.js 45.3 kB 0 B
build/editor/style-rtl.css 3.8 kB 0 B
build/editor/style.css 3.8 kB 0 B
build/element/index.js 4.65 kB 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/index.js 7.71 kB 0 B
build/format-library/style-rtl.css 547 B 0 B
build/format-library/style.css 548 B 0 B
build/hooks/index.js 2.13 kB 0 B
build/html-entities/index.js 621 B 0 B
build/i18n/index.js 3.56 kB 0 B
build/is-shallow-equal/index.js 711 B 0 B
build/keyboard-shortcuts/index.js 2.52 kB 0 B
build/keycodes/index.js 1.94 kB 0 B
build/list-reusable-blocks/index.js 3.12 kB 0 B
build/list-reusable-blocks/style-rtl.css 476 B 0 B
build/list-reusable-blocks/style.css 476 B 0 B
build/media-utils/index.js 5.31 kB 0 B
build/notices/index.js 1.79 kB 0 B
build/nux/index.js 3.4 kB 0 B
build/nux/style-rtl.css 671 B 0 B
build/nux/style.css 668 B 0 B
build/plugins/index.js 2.56 kB 0 B
build/primitives/index.js 1.41 kB 0 B
build/priority-queue/index.js 789 B 0 B
build/redux-routine/index.js 2.85 kB 0 B
build/rich-text/index.js 13.9 kB 0 B
build/server-side-render/index.js 2.77 kB 0 B
build/shortcode/index.js 1.69 kB 0 B
build/token-list/index.js 1.27 kB 0 B
build/url/index.js 4.06 kB 0 B
build/viewport/index.js 1.85 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.17 kB 0 B

compressed-size-action

@adamziel adamziel changed the title [edit-widgets] Pass correct rootClientId to the inserter [edit-widgets] Make global inserter usable by passing correct rootClientId to it Aug 28, 2020
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. I think the design is a separate issue as this was never refactored to use the "Panel" instead of the regular dropdown inserter.

@adamziel adamziel marked this pull request as ready for review September 15, 2020 14:01
@adamziel
Copy link
Contributor Author

One more change here would be inserting the widget to the most recently selected widget area instead of the first one as it happens ATM.

@adamziel adamziel force-pushed the update/fix-inserter-in-widgets-editor branch from 1e2b9bf to 7169f8b Compare September 16, 2020 11:31
@adamziel adamziel merged commit f3cdac3 into master Sep 16, 2020
@adamziel adamziel deleted the update/fix-inserter-in-widgets-editor branch September 16, 2020 12:21
@github-actions github-actions bot added this to the Gutenberg 9.1 milestone Sep 16, 2020
@paaljoachim
Copy link
Contributor

I see this has been merged.
Did the full regular Inserter panel with tabs for Block and Patterns get merged?

@adamziel
Copy link
Contributor Author

I don't think it was merged just yet @paaljoachim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Widgets Screen The block-based screen that replaced widgets.php. [Package] Edit Widgets /packages/edit-widgets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants