Fix Performance Tests on CI #24925
Merged
Fix Performance Tests on CI #24925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
youknowriad
commented
Aug 31, 2020
•
youknowriad
commented
- error handling
- timeout issue.
youknowriad
added
the
[Type] Automated Testing
|
Size Change: 0 B Total Size: 1.17 MB ℹ️ View Unchanged
|
ntsekouras
reviewed
Aug 31, 2020
| @@ -17,7 +17,7 @@ import { | |||
| const PUPPETEER_TIMEOUT = process.env.PUPPETEER_TIMEOUT; | |||
|
|
|||
| // The Jest timeout is increased because these tests are a bit slow | |||
| jest.setTimeout( PUPPETEER_TIMEOUT || 100000 ); | |||
| jest.setTimeout( PUPPETEER_TIMEOUT || 10000000 ); | |||
There was a problem hiding this comment.
Isn't this a really big timeout? Do we need it to be that big ( almost 3 hours )? I do not know the PUPPETEER_TIMEOUT env variable's value though..
There was a problem hiding this comment.
I think we don't really care about the timeout for the performance tests. They can take a long time if needed, what's important is the result of each typing key... The tests take a long time because they insert thousands of blocks and repeat the typing operation multiple times (same for selection)
There was a problem hiding this comment.
Now that the actual performance issue is fixed on master, the previous timeout should be sufficient though, so I restored it.
ntsekouras
approved these changes
Aug 31, 2020
|
Waiting for CI to see if it passes or not. |
youknowriad
force-pushed
the
fix/performance-ci
branch
from
06fe21a
to
852dc9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.