-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Disabled component infinite loop for a
elements
#24935
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-szabo97
added
the
[Type] Bug
An existing feature does not function as intended
label
Aug 31, 2020
david-szabo97
requested review from
vindl,
Copons,
jeyip,
noahtallen and
Addison-Stavlo
August 31, 2020 12:16
david-szabo97
requested review from
ajitbohra,
chrisvanpatten and
youknowriad
as code owners
August 31, 2020 12:16
Size Change: +182 B (0%) Total Size: 1.17 MB
ℹ️ View Unchanged
|
youknowriad
reviewed
Aug 31, 2020
youknowriad
approved these changes
Aug 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR here: #24397 not long ago, introduced a change the Disabled Component to disable hyperlink focusing. The change causes "infinite loop". Since we add
tabindex
toa
elements, but then we remove it immediately.This PR fixes it by adding an else-if to avoid the inifinite loop.
How has this been tested?
Screenshots
Before: (Notice
a
element keeps changing)After:
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: