Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/block parent selector component readme #24997

Merged
merged 2 commits into from
Sep 2, 2020
Merged

Fix/block parent selector component readme #24997

merged 2 commits into from
Sep 2, 2020

Conversation

JustinyAhin
Copy link
Member

Description

This PR fixed a mistake introduced in #24962 which has been merged earlier.
The imported component was Button instead of BlockParentSelector. And was imported from @wordpress/components instead of @wordpress/block-editor.

How has this been tested?

N/A, documentation only

Types of changes

Documentation

Checklist:

  • [n/a] My code is tested.
  • [n/a] My code follows the WordPress code style.
  • [n/a] My code follows the accessibility standards.
  • [n/a] My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@JustinyAhin JustinyAhin added the [Type] Developer Documentation Documentation for developers label Sep 2, 2020
youknowriad
youknowriad approved these changes Sep 2, 2020
View reviewed changes
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw, I invited you to the repository so you can review and also merge PRs when approved.

@aristath aristath merged commit 1e5044d into WordPress:master Sep 2, 2020
@github-actions github-actions bot added this to the Gutenberg 9.0 milestone Sep 2, 2020
@JustinyAhin
Copy link
Member Author

Btw, I invited you to the repository so you can review and also merge PRs when approved.

Thanks ;).

@JustinyAhin JustinyAhin deleted the fix/block-parent-selector-component-readme branch September 14, 2020 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youknowriad youknowriad youknowriad approved these changes

@ellatrix ellatrix Awaiting requested review from ellatrix

Assignees
No one assigned
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Milestone
Gutenberg 9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@JustinyAhin @youknowriad @aristath