Fix issue with gradient swatches stacking badly with scrollbar. #25002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
requested review from
ajitbohra,
chrisvanpatten and
youknowriad
as code owners
jasmussen
force-pushed
the
fix/gradient-swatch-regression
branch
from
0312d39
to
a79c93c
Compare
|
Size Change: +18 B (0%) Total Size: 1.17 MB
ℹ️ View Unchanged
|
|
@jasmussen Thanks for this! Will review shortly + fix up that failing JS Unit test (it looks like it's just the snapshots) |
|
There's something funky going on with my local dev I think... (trying to update snapshot tests) |
ItsJonQ
approved these changes
Sep 2, 2020
There was a problem hiding this comment.
🚀 from me! Tested locally and is working as expected. Thanks @jasmussen !
|
@jasmussen Will merge this once tests are green 🟢 ! |
|
Thank you for all the help! I'll merge when the checks pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small regression landed with gradient swatches recently. It looks fine with no scrollbar:
But it wraps badly when there is one:
This PR fixes that: