Allow enabling custom line heights using theme.json #25043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
Customization
youknowriad
requested review from
ellatrix,
spacedmonkey and
TimothyBJacobs
as code owners
youknowriad
commented
Sep 3, 2020
| @@ -136,6 +136,9 @@ | |||
| }, | |||
| "fontSize": { | |||
| "custom": true | |||
| }, | |||
| "lineHeight": { | |||
| "custom": false | |||
There was a problem hiding this comment.
unlike the previous one, this one is opt-in and doesn't have presets yet.
There was a problem hiding this comment.
For context, there's #23111 to create presets for line-height, padding, and margin that also lists previous experiments that were canceled.
There was a problem hiding this comment.
Perfect, it's a good way to test theme.json only presets.
11 tasks
|
Size Change: +2 B (0%) Total Size: 1.17 MB
ℹ️ View Unchanged
|
oandregal
approved these changes
Sep 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #20588
Similar to #24761 but for custom line-height.
The idea of this PR is to support disabling/enabling custom line-height support from theme.json while retaining backward compatibility for the disable-custom-font-sizes theme support flag.
Testing instructions