Bump @storybook/react major version #25161
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes some breakage related to dependency imports that we can see now on the playground:
Looking at
moment-timezone
theundefined is not an object (evaluating 'root.moment')
error means that for some reason Storybook is building the dependencies for the browser, and not passingwindow
into the context of the function. I think that Storybook fixed this import/build issue as a part of their new major version :)How has this been tested?
I was able to reproduce the error locally, and it's fixed when updating Storybook.
Types of changes
Bump
@storybook/react
, which was actually reporting that an upgrade was available.