Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump @storybook/react major version #25161

Merged
merged 2 commits into from
Sep 8, 2020
Merged

Bump @storybook/react major version #25161

merged 2 commits into from
Sep 8, 2020

Conversation

vcanales
Copy link
Member

@vcanales vcanales commented Sep 8, 2020

Description

This fixes some breakage related to dependency imports that we can see now on the playground:

Screen Shot 2020-09-08 at 13 26 26

Looking at moment-timezone the undefined is not an object (evaluating 'root.moment') error means that for some reason Storybook is building the dependencies for the browser, and not passing window into the context of the function. I think that Storybook fixed this import/build issue as a part of their new major version :)

How has this been tested?

I was able to reproduce the error locally, and it's fixed when updating Storybook.

Types of changes

Bump @storybook/react, which was actually reporting that an upgrade was available.

Fixes some breakage related to dependency imports.
Copy link
Member

@mkaz mkaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it out and upgrade seems to have fixed the issue.
I didn't notice any issues with the stories either.

Thanks 👍

@mkaz mkaz added the Storybook Storybook and its stories for components label Sep 8, 2020
The size of the output for `npm ls --json --long --prod` has grown to
around 110MB. For this reason, the output was being truncated at the
previous maximum buffer size, which was set at around ~104MB.
@vcanales
Copy link
Member Author

vcanales commented Sep 8, 2020

The License Check test was failing because the output of the npm ls --json --long --dev command grew over the maxBuffer setting of 104MB, to around 110MB. I increased the max buffer by a few megabytes to fix and give us a little bit of leeway. In the long run, we might run into this again, particularly because we don't know how our dependencies treat their respective dependencies, so we might want to reconsider how we define this buffer size limit.

@mkaz
Copy link
Member

mkaz commented Sep 8, 2020

Good catch @vcanales Thanks!

@mkaz mkaz merged commit 86cd404 into WordPress:master Sep 8, 2020
@github-actions github-actions bot added this to the Gutenberg 9.0 milestone Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Storybook Storybook and its stories for components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants