Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show Classic block contents on load #25162

Merged
merged 4 commits into from
Sep 8, 2020
Merged

Show Classic block contents on load #25162

merged 4 commits into from
Sep 8, 2020

Conversation

ntsekouras
Copy link
Contributor

Description

Fixes: #24696

With the update of React there seems to be some async changes that made the initialization of Classic block not to be triggered. This changes the event to hook on to load.

@ntsekouras ntsekouras added [Type] Bug An existing feature does not function as intended [Priority] High Used to indicate top priority items that need quick attention [Block] Classic Affects the Classic Editor Block labels Sep 8, 2020
@github-actions
Copy link

github-actions bot commented Sep 8, 2020 •
edited
Loading

Size Change: +19 B (0%)

Total Size: 1.2 MB

Filename Size Change
build/block-library/index.js 138 kB +19 B (0%)
ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.14 kB 0 B
build/annotations/index.js 3.67 kB 0 B
build/api-fetch/index.js 3.41 kB 0 B
build/autop/index.js 2.82 kB 0 B
build/blob/index.js 620 B 0 B
build/block-directory/index.js 8.5 kB 0 B
build/block-directory/style-rtl.css 953 B 0 B
build/block-directory/style.css 952 B 0 B
build/block-editor/index.js 128 kB 0 B
build/block-editor/style-rtl.css 11.1 kB 0 B
build/block-editor/style.css 11.1 kB 0 B
build/block-library/editor-rtl.css 8.64 kB 0 B
build/block-library/editor.css 8.64 kB 0 B
build/block-library/style-rtl.css 7.59 kB 0 B
build/block-library/style.css 7.58 kB 0 B
build/block-library/theme-rtl.css 754 B 0 B
build/block-library/theme.css 754 B 0 B
build/block-serialization-default-parser/index.js 1.88 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/blocks/index.js 47.7 kB 0 B
build/components/index.js 200 kB 0 B
build/components/style-rtl.css 15.5 kB 0 B
build/components/style.css 15.5 kB 0 B
build/compose/index.js 9.68 kB 0 B
build/core-data/index.js 12.3 kB 0 B
build/data-controls/index.js 1.29 kB 0 B
build/data/index.js 8.54 kB 0 B
build/date/index.js 31.9 kB 0 B
build/deprecated/index.js 772 B 0 B
build/dom-ready/index.js 568 B 0 B
build/dom/index.js 4.48 kB 0 B
build/edit-navigation/index.js 11.7 kB 0 B
build/edit-navigation/style-rtl.css 1.16 kB 0 B
build/edit-navigation/style.css 1.16 kB 0 B
build/edit-post/index.js 305 kB 0 B
build/edit-post/style-rtl.css 6.26 kB 0 B
build/edit-post/style.css 6.25 kB 0 B
build/edit-site/index.js 19.4 kB 0 B
build/edit-site/style-rtl.css 3.06 kB 0 B
build/edit-site/style.css 3.06 kB 0 B
build/edit-widgets/index.js 12.1 kB 0 B
build/edit-widgets/style-rtl.css 2.46 kB 0 B
build/edit-widgets/style.css 2.45 kB 0 B
build/editor/editor-styles-rtl.css 492 B 0 B
build/editor/editor-styles.css 493 B 0 B
build/editor/index.js 45.6 kB 0 B
build/editor/style-rtl.css 3.81 kB 0 B
build/editor/style.css 3.81 kB 0 B
build/element/index.js 4.64 kB 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/index.js 7.71 kB 0 B
build/format-library/style-rtl.css 547 B 0 B
build/format-library/style.css 548 B 0 B
build/hooks/index.js 2.13 kB 0 B
build/html-entities/index.js 622 B 0 B
build/i18n/index.js 3.57 kB 0 B
build/is-shallow-equal/index.js 711 B 0 B
build/keyboard-shortcuts/index.js 2.52 kB 0 B
build/keycodes/index.js 1.95 kB 0 B
build/list-reusable-blocks/index.js 3.12 kB 0 B
build/list-reusable-blocks/style-rtl.css 476 B 0 B
build/list-reusable-blocks/style.css 476 B 0 B
build/media-utils/index.js 5.32 kB 0 B
build/notices/index.js 1.79 kB 0 B
build/nux/index.js 3.4 kB 0 B
build/nux/style-rtl.css 671 B 0 B
build/nux/style.css 668 B 0 B
build/plugins/index.js 2.56 kB 0 B
build/primitives/index.js 1.41 kB 0 B
build/priority-queue/index.js 789 B 0 B
build/redux-routine/index.js 2.85 kB 0 B
build/rich-text/index.js 13.9 kB 0 B
build/server-side-render/index.js 2.77 kB 0 B
build/shortcode/index.js 1.7 kB 0 B
build/token-list/index.js 1.27 kB 0 B
build/url/index.js 4.06 kB 0 B
build/viewport/index.js 1.85 kB 0 B
build/warning/index.js 1.13 kB 0 B
build/wordcount/index.js 1.17 kB 0 B

compressed-size-action

@sirreal
Copy link
Member

sirreal commented Sep 8, 2020

This does appear to fix the issue in question in my testing.

@youknowriad
Copy link
Contributor

If someone has time later, this is a good opportunity for an e2e test

  • add classic block
  • add content
  • save
  • reload
  • check rendered content
  • switch to code editor and back
  • check rendered content

ockham
ockham approved these changes Sep 8, 2020
View reviewed changes
Copy link
Contributor

@ockham ockham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Confirming that this is fixing #24696, per the latest commit (f4fadf4)

:shipit:

@ockham ockham merged commit 65c9f74 into master Sep 8, 2020
@ockham ockham deleted the fix/edit-classic-block-edit-on-load branch September 8, 2020 19:19
@github-actions github-actions bot added this to the Gutenberg 9.0 milestone Sep 8, 2020
mcsf pushed a commit that referenced this pull request Sep 8, 2020
@ntsekouras @mcsf
Show Classic block contents on load (#25162)
8173dbc
@fullofcaffeine
Copy link
Member

If someone has time later, this is a good opportunity for an e2e test

  • add classic block
  • add content
  • save
  • reload
  • check rendered content
  • switch to code editor and back
  • check rendered content

I will take this one for a spin.

@fullofcaffeine fullofcaffeine mentioned this pull request Sep 9, 2020
Merged
6 tasks
@sirreal sirreal mentioned this pull request Sep 9, 2020
Merged
6 tasks
ockham added a commit that referenced this pull request Sep 10, 2020
@fullofcaffeine @ockham
Add regression E2E test for the classic block initialization issue (#…
d7cda50 
…25169)

Adds a regression test in the client block E2E spec to avoid the regression of the Classic block, per this issue:  #24696, as suggested in #25162 (comment).

Co-authored-by: Bernie Reiter <ockham@raz.or.at>
@ntsekouras ntsekouras mentioned this pull request Sep 15, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youknowriad youknowriad youknowriad left review comments

@ockham ockham ockham approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@Soean Soean Awaiting requested review from Soean

@talldan talldan Awaiting requested review from talldan

Assignees
No one assigned
Labels
[Block] Classic Affects the Classic Editor Block [Priority] High Used to indicate top priority items that need quick attention [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
Gutenberg 9.0
Development

Successfully merging this pull request may close these issues.

Unable to edit Classic Block on regular (web) editor
5 participants
@ntsekouras @sirreal @youknowriad @fullofcaffeine @ockham