Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Navigation: Implement redesign of Navigation Editor #25178
Navigation: Implement redesign of Navigation Editor #25178
Changes from 19 commits
53f11de
7ba8452
7efa781
7f59c24
96db71a
3f1eaf6
22750a8
18341e8
5888c7a
79026cf
86440fa
cd405b7
a758ad2
90c2b58
143df0b
f5cdbbb
c19c449
93f5efa
62211f0
6e5df7d
4a7da3f
08980a2
bdc1cdc
1b668fb
74d6a8b
f4e9bb9
a094256
417ee55
bf6aefa
6125e6f
80215a7
5d06320
d02bcb8
3ba5109
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens when
blocks
changes?For example, it changes from
[1, 2, 3]
to[4, 5, 6]
.selectedBlockId
is now out of sync, should we care about this at all?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be honest I'm not even sure why we're using local state instead of
select( 'core/block-editor' ).getSelectedBlockClientId()
. Maybe @talldan knows?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was already this way in
master
, so I've made a note to come back to this later.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this was @adamziel's change, #22705 should be the issue relating to the code.