Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow moving metaboxes to previously empty area #25187

Merged
merged 12 commits into from
Oct 25, 2021
Merged

Allow moving metaboxes to previously empty area #25187

Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
aa86f59
Fixes #7960
aristath Sep 9, 2020
a3497f5
Merge branch 'master' into fix/visible-metaboxes-7960
aristath Sep 10, 2020
111e1cd
Remove isVisible from withSelect
aristath Sep 10, 2020
8e2eeae
Merge branch 'master' into fix/visible-metaboxes-7960
aristath Sep 21, 2020
fa0f126
Merge branch 'master' into fix/visible-metaboxes-7960
aristath Oct 9, 2020
e16785a
Merge branch 'master' into fix/visible-metaboxes-7960
aristath Nov 30, 2020
b02eeb3
Merge branch 'master' into fix/visible-metaboxes-7960
aristath Jan 8, 2021
777faae
Merge branch 'master' into fix/visible-metaboxes-7960
aristath Jan 8, 2021
16a7f95
Merge branch 'trunk' into fix/visible-metaboxes-7960
aristath Apr 23, 2021
3f5cf86
Merge branch 'trunk' into fix/visible-metaboxes-7960
aristath May 27, 2021
2b7b297
Merge branch 'trunk' into fix/visible-metaboxes-7960
ribaricplusplus Oct 24, 2021
1b5fa77
Restore some files from trunk
ribaricplusplus Oct 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions packages/edit-post/src/components/meta-boxes/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,22 +19,15 @@ import { store as editPostStore } from '../../store';

export default function MetaBoxes( { location } ) {
const registry = useRegistry();
const {
metaBoxes,
isVisible,
areMetaBoxesInitialized,
isEditorReady,
} = useSelect(
const { metaBoxes, areMetaBoxesInitialized, isEditorReady } = useSelect(
( select ) => {
const { __unstableIsEditorReady } = select( editorStore );
const {
isMetaBoxLocationVisible,
getMetaBoxesPerLocation,
areMetaBoxesInitialized: _areMetaBoxesInitialized,
} = select( editPostStore );
return {
metaBoxes: getMetaBoxesPerLocation( location ),
isVisible: isMetaBoxLocationVisible( location ),
areMetaBoxesInitialized: _areMetaBoxesInitialized(),
isEditorReady: __unstableIsEditorReady(),
};
Expand All @@ -60,7 +53,7 @@ export default function MetaBoxes( { location } ) {
{ map( metaBoxes, ( { id } ) => (
<MetaBoxVisibility key={ id } id={ id } />
) ) }
{ isVisible && <MetaBoxesArea location={ location } /> }
<MetaBoxesArea location={ location } />
</>
);
}