Canceling Drag and Drop with ESC immediately hides dropzone bar (#24204) #25317
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes #24204
When canceling a drag and drop operation by pressing "ESC", the blue dropzone bar will now immediately disappear.
Previously, it would only disappear after the next "Mouse Up" event. If you pressed ESC, kept the mouse button held, moved the mouse outside the browser then released the button, the blue bar would be showing indefinitely.
How has this been tested?
Tested manually by running
wp-env start
andnpm run dev
.Screenshots
Before fix:
After fix:
Types of changes
isDraggingBlocks()
selector is now also checked when deciding to render theis-drop-target
class. Previously, only thedropTargetIndex
was being checked.Checklist: