Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mobile] Buttons Block: Adds debounce in the add button action #25376

Merged
merged 2 commits into from
Sep 18, 2020

Conversation

antonis
Copy link
Member

@antonis antonis commented Sep 16, 2020

Fixes wordpress-mobile/gutenberg-mobile#2238

Gutenberg Mobile PR -> wordpress-mobile/gutenberg-mobile#2625

Description

Behavior without the fix

iOS: When user taps fast multiple times on side "+" icon to add multiple buttons the app falls in a loop
Android: When user taps fast multiple times on side "+" icon to add multiple buttons the app temporary freeze and the buttons are eventually created.

Fix

A debounce has been added in the add button action.
Extending the fix to the ButtonBlockAppender was considered but the reported bug was not reproduced in any other block using it. Thus adding a delay on user action was not considered necessary.

How has this been tested?

  • Create a post or page
  • Add a buttons block
  • Tap fast multiple times on side "+" icon to add multiple buttons.
  • Confirm that the app does not fall in a loop (iOS) or freezes (Android)

Screenshots

Without the fix With the fix

Types of changes

Bug fix

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@antonis antonis added [Type] Bug An existing feature does not function as intended [Block] Buttons Affects the Buttons Block labels Sep 16, 2020
@antonis antonis self-assigned this Sep 16, 2020
@antonis antonis changed the title Buttons Block: Adds debounce in the add button action [Mobile] Buttons Block: Adds debounce in the add button action Sep 16, 2020
@antonis antonis added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Sep 16, 2020
@github-actions
Copy link

github-actions bot commented Sep 16, 2020

Size Change: +664 B (0%)

Total Size: 1.2 MB

Filename Size Change
build/block-editor/index.js 128 kB +281 B (0%)
build/block-editor/style-rtl.css 11.1 kB +67 B (0%)
build/block-editor/style.css 11.1 kB +62 B (0%)
build/block-library/index.js 135 kB +237 B (0%)
build/components/index.js 201 kB -7 B (0%)
build/edit-site/index.js 19 kB +24 B (0%)
ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.14 kB 0 B
build/annotations/index.js 3.67 kB 0 B
build/api-fetch/index.js 3.41 kB 0 B
build/autop/index.js 2.83 kB 0 B
build/blob/index.js 620 B 0 B
build/block-directory/index.js 8.53 kB 0 B
build/block-directory/style-rtl.css 943 B 0 B
build/block-directory/style.css 942 B 0 B
build/block-library/editor-rtl.css 8.59 kB 0 B
build/block-library/editor.css 8.59 kB 0 B
build/block-library/style-rtl.css 7.6 kB 0 B
build/block-library/style.css 7.59 kB 0 B
build/block-library/theme-rtl.css 741 B 0 B
build/block-library/theme.css 741 B 0 B
build/block-serialization-default-parser/index.js 1.88 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/blocks/index.js 47.8 kB 0 B
build/components/style-rtl.css 15.5 kB 0 B
build/components/style.css 15.4 kB 0 B
build/compose/index.js 9.68 kB 0 B
build/core-data/index.js 12.2 kB 0 B
build/data-controls/index.js 1.28 kB 0 B
build/data/index.js 8.55 kB 0 B
build/date/index.js 31.9 kB 0 B
build/deprecated/index.js 772 B 0 B
build/dom-ready/index.js 568 B 0 B
build/dom/index.js 4.48 kB 0 B
build/edit-navigation/index.js 10.7 kB 0 B
build/edit-navigation/style-rtl.css 868 B 0 B
build/edit-navigation/style.css 871 B 0 B
build/edit-post/index.js 305 kB 0 B
build/edit-post/style-rtl.css 6.24 kB 0 B
build/edit-post/style.css 6.22 kB 0 B
build/edit-site/style-rtl.css 3.13 kB 0 B
build/edit-site/style.css 3.13 kB 0 B
build/edit-widgets/index.js 16.4 kB 0 B
build/edit-widgets/style-rtl.css 2.75 kB 0 B
build/edit-widgets/style.css 2.75 kB 0 B
build/editor/editor-styles-rtl.css 492 B 0 B
build/editor/editor-styles.css 493 B 0 B
build/editor/index.js 45.3 kB 0 B
build/editor/style-rtl.css 3.8 kB 0 B
build/editor/style.css 3.8 kB 0 B
build/element/index.js 4.65 kB 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/index.js 7.71 kB 0 B
build/format-library/style-rtl.css 547 B 0 B
build/format-library/style.css 548 B 0 B
build/hooks/index.js 2.13 kB 0 B
build/html-entities/index.js 621 B 0 B
build/i18n/index.js 3.56 kB 0 B
build/is-shallow-equal/index.js 711 B 0 B
build/keyboard-shortcuts/index.js 2.52 kB 0 B
build/keycodes/index.js 1.94 kB 0 B
build/list-reusable-blocks/index.js 3.12 kB 0 B
build/list-reusable-blocks/style-rtl.css 476 B 0 B
build/list-reusable-blocks/style.css 476 B 0 B
build/media-utils/index.js 5.32 kB 0 B
build/notices/index.js 1.79 kB 0 B
build/nux/index.js 3.4 kB 0 B
build/nux/style-rtl.css 671 B 0 B
build/nux/style.css 668 B 0 B
build/plugins/index.js 2.56 kB 0 B
build/primitives/index.js 1.41 kB 0 B
build/priority-queue/index.js 789 B 0 B
build/redux-routine/index.js 2.85 kB 0 B
build/rich-text/index.js 13.9 kB 0 B
build/server-side-render/index.js 2.77 kB 0 B
build/shortcode/index.js 1.69 kB 0 B
build/token-list/index.js 1.27 kB 0 B
build/url/index.js 4.06 kB 0 B
build/viewport/index.js 1.85 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.17 kB 0 B

compressed-size-action

@antonis antonis requested a review from lukewalczak September 18, 2020 07:11
Copy link
Member

@lukewalczak lukewalczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, it works so much better!

@antonis antonis merged commit 43b79ad into master Sep 18, 2020
@antonis antonis deleted the rnmobile/2238_AddButtonsDebounce branch September 18, 2020 08:57
@github-actions github-actions bot added this to the Gutenberg 9.1 milestone Sep 18, 2020
@pinarol
Copy link
Contributor

pinarol commented Sep 18, 2020

Great fix! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Buttons Affects the Buttons Block Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants