-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mobile] Buttons Block: Adds debounce in the add button action #25376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Size Change: +664 B (0%) Total Size: 1.2 MB
ℹ️ View Unchanged
|
lukewalczak
reviewed
Sep 17, 2020
lukewalczak
approved these changes
Sep 18, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, it works so much better!
Great fix! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Block] Buttons
Affects the Buttons Block
Mobile App - i.e. Android or iOS
Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
[Type] Bug
An existing feature does not function as intended
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes wordpress-mobile/gutenberg-mobile#2238
Gutenberg Mobile PR
-> wordpress-mobile/gutenberg-mobile#2625Description
Behavior without the fix
iOS: When user taps fast multiple times on side "+" icon to add multiple buttons the app falls in a loop
Android: When user taps fast multiple times on side "+" icon to add multiple buttons the app temporary freeze and the buttons are eventually created.
Fix
A debounce has been added in the add button action.
Extending the fix to the
ButtonBlockAppender
was considered but the reported bug was not reproduced in any other block using it. Thus adding a delay on user action was not considered necessary.How has this been tested?
Screenshots
Types of changes
Bug fix
Checklist: