-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mobile] Re add the default colour palette and gradients #25523
Conversation
Size Change: 0 B Total Size: 1.17 MB ℹ️ View Unchanged
|
Thanks for the quick fix @enejb. Could you also open an issue to discuss the more ideal solution where we read the default colors/gradients from its new place(theme.json)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested using the demo app on Android it's working for me 👍 Thanks for the fix here. I think this branch just needs to be updated with the adding back in of the fonts.
dc64215
to
2a4a7e3
Compare
2a4a7e3
to
c97c029
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like you mention in wordpress-mobile/gutenberg-mobile#2649 (comment), I'm also still seeing the Cancel and Apply buttons go missing. I don't see a problem in the current WPiOS 15.7 app. I can file a separate issue so that this PR can close wordpress-mobile/gutenberg-mobile#2649, is that OK?
I also noticed a separate issue where I can't add text to Button blocks (I'll update with a link to an issue once it's created updated) — but the issue is not related to this PR (it's also present on the master
branch).
I filed a separate issue #25646 for the missing "Cancel" and "Apply" buttons. |
Description
Fixes wordpress-mobile/gutenberg-mobile#2649
By adding the default colour palette and gradients back to the mobile side that were removed on the web side in #25419
How has this been tested?
I tested in on the GB Mobile demo app.
Screenshots
Types of changes
Fixes a regression in terms of default color palette and gradients.
Checklist: