Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile - Fix Buttons block text input #25624

Merged
merged 6 commits into from
Sep 28, 2020
Merged

Mobile - Fix Buttons block text input #25624

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ca7217e
Mobile - Fix Buttons block text input
Sep 24, 2020
6556ace
Mobile - RichText - Add missing props for native
Sep 24, 2020
cfbc833
Merge branch 'master' into rnmobile/fix/buttons-text
Sep 24, 2020
8e8e452
Mobile - RichText - Pass id prop to native component
Sep 25, 2020
09f46b0
Mobile - RichText - Add comment for mobile prop
Sep 25, 2020
a0def96
Mobile - RichText - update comment
Sep 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions packages/block-editor/src/components/rich-text/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,10 @@ function RichTextWrapper(
fontFamily,
fontWeight,
fontStyle,
minWidth,
maxWidth,
onBlur,
setRef,
...props
},
forwardedRef
Expand Down Expand Up @@ -603,6 +607,13 @@ function RichTextWrapper(
fontFamily={ fontFamily }
fontWeight={ fontWeight }
fontStyle={ fontStyle }
minWidth={ minWidth }
maxWidth={ maxWidth }
onBlur={ onBlur }
setRef={ setRef }
// Destructuring the id prop before { ...props } doesn't work
// correctly on web https://github.com/WordPress/gutenberg/pull/25624
id={ props.id }
geriux marked this conversation as resolved.
Show resolved Hide resolved
lukewalczak marked this conversation as resolved.
Show resolved Hide resolved
>
{ ( {
isSelected: nestedIsSelected,
Expand Down