Export and document LinkControl's building blocks #25901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamziel
added
the
[Feature] Link Editing
|
Size Change: -2.14 kB (0%) Total Size: 1.19 MB
ℹ️ View Unchanged
|
|
I like this approach for allowing folks to build out custom UIs. I still believe the top-level monolith component isn't necessarily a bad thing as it retains a consistent UI for 90% of use cases. With this approach to exposing the lower-level components, we can service the 10% (disclaimer: those figures are completely arbitrary!). |
getdave
approved these changes
Oct 7, 2020
There was a problem hiding this comment.
Technically this looks sound.
Two points that seem minor:
- Is it better to export the
defaultfrom the sub component files directly, or export them as non-default exports from the mainLinkControlfile? That way you could do:
import __experimentalLinkControl, { __experimentalLinkControlSearchInput } from 'block-editor/link-control
This approach might not couple us to filenames. That said, if there's a convention let's stick with that.
- Should we update the docs to reflect these changes, even if it's just to say "We now export the lower level components"?
adamziel
force-pushed
the
update/export-granular-link-control-pieces
branch
from
53ef92b to
2e36b04
Compare
|
@getdave @swissspidy I drafted how an updated README could look like - I'd appreciate your feedback. |
adamziel
changed the title
getdave
approved these changes
Oct 14, 2020
Co-authored-by: Dave Smith <getdavemail@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
<LinkControl />used to be all-or-nothing monolith. As of #23869 it's composed using more granular building blocks. While it's still not perfect, these building blocks could already be useful for building custom UIs that are visually consistent with the rest of Gutenberg. This PR exposes some of these components using__experimentalprefix. If the response is positive, I will follow up by adding usage examples to README.Checklist: