-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cover: Add repeated background option #26001
Conversation
Size Change: +106 B (0%) Total Size: 1.19 MB
ℹ️ View Unchanged
|
This is a very cool PR! Thank you for creating the various videos! They show a nice overview of the creativity that one can add by repeating a pattern. I have also tested the PR. One thing that comes to mind is how the Customizer handles the Background Image. Here is an example of adding the same drop down to Gutenberg Cover block. I will ping: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just tested this PR and it works well. 👍
I do like @paaljoachim's comment about including a few more options as the Customizer does, but I don't want to hold up this PR. Maybe we can get this in and then work toward those other options in another PR?
Yes. I do like it too, but wondering whether it should be adapted to the final user. I mean maybe it isn't totally clear what means every background option.
👍
Sounds good to me. Thanks. |
214eb55
to
35561cd
Compare
@retrofox I think this may have broken unit tests for the repo -- I think |
Fix in #26044, I think |
Sorry, my bad. I didn't realize it. 🤦 Thank you very much for fixing it. It won't happen again. |
Awesome feature btw! :) |
Description
This PR adds the
Repeated Background
option to thecore/cover
block.How has this been tested?
Create a cover block
Add an image as the background
Open the Block settings sidebar
Confirm you see the
Repeated Background
just below toFixed Background
Play with different combinations
Screenshots
Video Demos
Checklist: