Fix drag and drop in empty widget area #26051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Bug
talldan
requested review from
adamziel,
draganescu,
kevin940726,
noisysocks,
tellthemachines and
youknowriad
as code owners
talldan
commented
Oct 13, 2020
| .wp-block-widget-area > .components-panel__body > .block-editor-inner-blocks { | ||
| // Add some spacing above the inner blocks so that the block toolbar doesn't | ||
| // overlap the panel header. | ||
| .wp-block-widget-area > .components-panel__body > div > .block-editor-inner-blocks { |
There was a problem hiding this comment.
I've also fixed this selector, which was broken, and added some comments for both.
|
Size Change: +54 B (0%) Total Size: 1.19 MB
ℹ️ View Unchanged
|
adamziel
approved these changes
Oct 13, 2020
|
Works great! 🚢 |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #25911.
The issue is that the Inner Blocks area being dragged into has collapsed to
0pxheight. Since the Inner Blocks area represents the drop zone for blocks there was effectively no drop target.This PR ensures there's a min-height on widget area inner blocks. The drop target is still not perfect, but it is at least possible now.
Ideally the whole widget area block could act as a drop zone, I've documented in #26049, but given I'm not sure of the feasibility of that, this seems like a good incremental fix.
How has this been tested?
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: