Update dropdown-menu and button to allow text buttons #26425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkaz
added
[Feature] UI Components
|
Size Change: +32 B (0%) Total Size: 1.21 MB
ℹ️ View Unchanged
|
mkaz
force-pushed
the
add/dropdown-menu-text
branch
2 times, most recently
from
b3da2c9 to
aafd939
Compare
Adds a new text property for button and dropdownmenu, if specified it
will show the text in the button field. You could specify icon={ null }
to have a text-only button.
Used to support social links size menu in #25921
- Show text if specified regardless of icon, allows for icon & text - Switch text rendering, don't need a span tag, just use a fragment
mkaz
force-pushed
the
add/dropdown-menu-text
branch
from
aafd939 to
9cb4ebf
Compare
jasmussen
approved these changes
Oct 30, 2020
There was a problem hiding this comment.
The checks are passing 🤯 could it be !?
In any case, this is testing well for me:
That is ... we are not going to be adding that "More" label to the dropdown as shown in the screenshot here, that's just for testing.
Question: is there a better term than "text" for this property? Nothing comes to mind since label is already used, and serves as a tooltip/additional info.
Otherwise, seems good to me and just needs a code sanity check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In support of Social links size option (#25921) this PR adds the ability to show a dropdown-menu button with icon and/or text. Previously, you would need to create a custom control using the lower-level Dropdown component, for example the Replace image toolbar.
How has this been tested?
Confirm once applied nothing changes in existing DropdownMenus
Alter a DropdownMenu component being used to include the additional text prop
For example, update
packages/block-editor/src/components/rich-text/format-toolbar/index.jsand add a text prop, for example:You can test text-only buttons by setting
icon={ null }Screenshots
Types of changes
Checklist: