Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the docblock for the widget_comments_args filter #26618

Merged
merged 1 commit into from
Nov 7, 2020

Conversation

johnbillion
Copy link
Member

Description

The docblock for this filter is not in the correct place. This means that libraries that scan WordPress core for actions and filters (including WP Parser on developer.wordpress.org) see this filter twice.

How has this been tested?

This has been tested by running the wp-hooks action and filter documentation generator over WordPress core with this change in place and verifying that the filter only appears once.

Types of changes

Bug fix

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

Copy link
Member

@ajitbohra ajitbohra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

johnbillion added a commit to wp-hooks/wordpress-core-hooks that referenced this pull request Oct 31, 2020
@gziolo gziolo added [Type] Developer Documentation Documentation for developers [Feature] Extensibility The ability to extend blocks or the editing experience labels Nov 7, 2020
@gziolo gziolo merged commit 2b7bb8c into WordPress:master Nov 7, 2020
@github-actions github-actions bot added this to the Gutenberg 9.4 milestone Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Extensibility The ability to extend blocks or the editing experience [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants