Add new hook for Gutenberg latest posts block

[romain-d]

Hello,

following my error on the WordPress trac, I redo this PR here.
FYI https://core.trac.wordpress.org/ticket/51694

Add a hook to changes arguments of Gutenberg latests posts block query

Romain DORR, Be API

[noisysocks]

Thanks @romain-d. Looks good, two notes:

1. Let's drop core and simply name this filter block_latest_posts_query_args. In WordPress, filters that don't have a prefix are implicitly core filters.

2. Could you please add a doc comment before the apply_filter which explains what this filter does? You can see an example of what one of these looks like here. In this case we'll want @since 5.7.0.

[romain-d]

Hi @noisysocks ,

Thanks for the feedback, I made the requested changes.

Best,
Romain DORR, Be API.

[noisysocks]

@romain-d: Could you please rebase master into this branch? There are some unrelated E2E test failures that are preventing us from getting a ✅.

[noahtallen]

Nice stuff!

[youknowriad]

I'm not really sure adding an adhoc hook for a specific block is a good idea? were there any discussion about this?

[gziolo]

There is already a general-purpose hook for modifying block's data: render_block_data. There are more filters that let you hook into the rendering process. It would be great to know what type of customization they aren't covering.

[mcsf]

I'm not really sure adding an adhoc hook for a specific block is a good idea? were there any discussion about this?

Agreed. Unless there is a really compelling for this block-specific hook, it seems important to revert so as not to open a precedent.

[noahtallen]

It seems like the use case would be adding or removing an argument to the query which gets the latest posts for the block. That doesn't seem possible with the existing hooks

[youknowriad]

Sometimes, it's not about it being possible or not. We need to make hard decisions. In this particular instance, someone could just replace the latest post block by his own block or override the render function. Yes, it's not as simple as a simple hook but it's better than having adhoc hook that we'll be forced to maintain. Especially since the Query block is meant to replace that block anyway.

[noahtallen]

@youknowriad I added a revert here since I merged this: #27078

[youknowriad]

Thank you Noah