Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating some native mobile UI tests #26691

Merged
merged 3 commits into from
Nov 6, 2020
Merged

Updating some native mobile UI tests #26691

merged 3 commits into from
Nov 6, 2020

Conversation

hypest
Copy link
Contributor

@hypest hypest commented Nov 4, 2020 •
edited
Loading

Description

PR to update some native mobile UI tests that fail locally.

How has this been tested?

Locally on an Android 10 device (Pixel 2 XL) via issuing npm run test:e2e:android:local and on an iOS v14.1 simulator via npm run test:e2e:ios:local.

Types of changes

  • swipeUp not needed; performed via removeBlockAtPosition on Android
  • Dismissing Android 10's clipboard paste auto-suggestion popup so the test can continue as it was. Here's a screenshot of how that popup looks:

The updated code is dismissing the popup by looking for the `Dismiss Smart Suggestion` content-description and tapping on it.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@hypest hypest added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Nov 4, 2020
@github-actions
Copy link

github-actions bot commented Nov 4, 2020 •
edited
Loading

Size Change: 0 B

Total Size: 1.21 MB

ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.14 kB 0 B
build/annotations/index.js 3.78 kB 0 B
build/api-fetch/index.js 3.45 kB 0 B
build/autop/index.js 2.84 kB 0 B
build/blob/index.js 665 B 0 B
build/block-directory/index.js 8.72 kB 0 B
build/block-directory/style-rtl.css 943 B 0 B
build/block-directory/style.css 942 B 0 B
build/block-editor/index.js 131 kB 0 B
build/block-editor/style-rtl.css 11.1 kB 0 B
build/block-editor/style.css 11.1 kB 0 B
build/block-library/editor-rtl.css 9.02 kB 0 B
build/block-library/editor.css 9.02 kB 0 B
build/block-library/index.js 146 kB 0 B
build/block-library/style-rtl.css 7.9 kB 0 B
build/block-library/style.css 7.89 kB 0 B
build/block-library/theme-rtl.css 792 B 0 B
build/block-library/theme.css 793 B 0 B
build/block-serialization-default-parser/index.js 1.88 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/blocks/index.js 48.1 kB 0 B
build/components/index.js 172 kB 0 B
build/components/style-rtl.css 15.3 kB 0 B
build/components/style.css 15.2 kB 0 B
build/compose/index.js 9.81 kB 0 B
build/core-data/index.js 12.5 kB 0 B
build/data-controls/index.js 772 B 0 B
build/data/index.js 8.77 kB 0 B
build/date/index.js 31.8 kB 0 B
build/deprecated/index.js 768 B 0 B
build/dom-ready/index.js 571 B 0 B
build/dom/index.js 4.46 kB 0 B
build/edit-navigation/index.js 11.2 kB 0 B
build/edit-navigation/style-rtl.css 881 B 0 B
build/edit-navigation/style.css 885 B 0 B
build/edit-post/index.js 306 kB 0 B
build/edit-post/style-rtl.css 6.41 kB 0 B
build/edit-post/style.css 6.39 kB 0 B
build/edit-site/index.js 22.5 kB 0 B
build/edit-site/style-rtl.css 3.88 kB 0 B
build/edit-site/style.css 3.88 kB 0 B
build/edit-widgets/index.js 26.3 kB 0 B
build/edit-widgets/style-rtl.css 3.13 kB 0 B
build/edit-widgets/style.css 3.13 kB 0 B
build/editor/editor-styles-rtl.css 480 B 0 B
build/editor/editor-styles.css 482 B 0 B
build/editor/index.js 43.1 kB 0 B
build/editor/style-rtl.css 3.85 kB 0 B
build/editor/style.css 3.85 kB 0 B
build/element/index.js 4.65 kB 0 B
build/escape-html/index.js 735 B 0 B
build/format-library/index.js 7.7 kB 0 B
build/format-library/style-rtl.css 547 B 0 B
build/format-library/style.css 548 B 0 B
build/hooks/index.js 2.16 kB 0 B
build/html-entities/index.js 623 B 0 B
build/i18n/index.js 3.57 kB 0 B
build/is-shallow-equal/index.js 712 B 0 B
build/keyboard-shortcuts/index.js 2.52 kB 0 B
build/keycodes/index.js 1.94 kB 0 B
build/list-reusable-blocks/index.js 3.11 kB 0 B
build/list-reusable-blocks/style-rtl.css 476 B 0 B
build/list-reusable-blocks/style.css 476 B 0 B
build/media-utils/index.js 5.34 kB 0 B
build/notices/index.js 1.79 kB 0 B
build/nux/index.js 3.42 kB 0 B
build/nux/style-rtl.css 671 B 0 B
build/nux/style.css 668 B 0 B
build/plugins/index.js 2.56 kB 0 B
build/primitives/index.js 1.43 kB 0 B
build/priority-queue/index.js 791 B 0 B
build/redux-routine/index.js 2.85 kB 0 B
build/reusable-blocks/index.js 3.06 kB 0 B
build/rich-text/index.js 13.2 kB 0 B
build/server-side-render/index.js 2.77 kB 0 B
build/shortcode/index.js 1.69 kB 0 B
build/token-list/index.js 1.27 kB 0 B
build/url/index.js 4.06 kB 0 B
build/viewport/index.js 1.84 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.22 kB 0 B

compressed-size-action

@hypest hypest force-pushed the gbmobile/fix-e2e-tests-locally branch from 004fe98 to d9e55fb Compare November 5, 2020 12:49
@hypest hypest requested a review from jd-alexander November 5, 2020 15:06
@hypest hypest marked this pull request as ready for review November 5, 2020 15:06
@hypest hypest mentioned this pull request Nov 5, 2020
Merged
6 tasks
jd-alexander
jd-alexander reviewed Nov 6, 2020
View reviewed changes
Copy link
Contributor

@jd-alexander jd-alexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these changes @hypest The code looks good! The tests have been successful on Android so far but I haven't been able to reproduce the auto-suggestions pop up on my emulator. Is there a setting I might need to enable?

@hypest
Copy link
Contributor Author

hypest commented Nov 6, 2020 •
edited
Loading

I haven't been able to reproduce the auto-suggestions pop up on my emulator. Is there a setting I might need to enable?

Ah, not sure @jd-alexander. I've only noticed this on my physical Pixel 2XL, haven't tried an Android 10 emulator, although I did try an Android 8 emulator to make sure the "trick" is not breaking the tests on other Android versions. I'll try to spin up an Android 10 emulator on my side to check. Edit: can't make the Android 10 emulator do it, perhaps it's a feature only on the Pixel phones 🤔.

@hypest
Copy link
Contributor Author

hypest commented Nov 6, 2020

Also, let me know what you think about optimistically merging this since it doesn't seem to break the existing tests, and it's not a functional change anyway.

@jd-alexander
Copy link
Contributor

Also, let me know what you think about optimistically merging this since it doesn't seem to break the existing tests, and it's not a functional change anyway.

I'm totally fine with this 🙏🏾

jd-alexander
jd-alexander approved these changes Nov 6, 2020
View reviewed changes
Copy link
Contributor

@jd-alexander jd-alexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests pass on Android and iOS. LGTM 🚢

@jd-alexander jd-alexander merged commit 5287a71 into master Nov 6, 2020
@jd-alexander jd-alexander deleted the gbmobile/fix-e2e-tests-locally branch November 6, 2020 16:27
@github-actions github-actions bot added this to the Gutenberg 9.4 milestone Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jd-alexander jd-alexander jd-alexander approved these changes

Assignees

@jd-alexander jd-alexander

Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Milestone
Gutenberg 9.4
Development

Successfully merging this pull request may close these issues.
2 participants
@hypest @jd-alexander