Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dynamic height to separator block #26764

Closed
wants to merge 2 commits into from
Closed

Add dynamic height to separator block #26764

wants to merge 2 commits into from

Conversation

simison
Copy link
Member

@simison simison commented Nov 6, 2020 •
edited
Loading

WIP — feel free to take this PR over! I likely won't have time very soon to finish this. Needs a rebase.

Description

Adds draggable UI and settings input to the separator block to adjust empty space around above and below it.

Resolves #25989

How has this been tested?

  • WIP

Screenshots

Types of changes

New feature.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@simison simison added [Status] In Progress Tracking issues with work in progress [Block] Separator Affects the Separator Block labels Nov 6, 2020
@simison simison mentioned this pull request Nov 6, 2020
Closed
@paaljoachim paaljoachim mentioned this pull request Jan 22, 2021
Closed
6 tasks
Base automatically changed from master to trunk March 1, 2021 15:44
@scruffian scruffian mentioned this pull request Apr 27, 2022
Closed
@simison simison closed this Jul 26, 2023
@simison simison deleted the update/separator-dynamic-height branch July 26, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra will be requested when the pull request is marked ready for review ajitbohra is a code owner

@fabiankaegy fabiankaegy Awaiting requested review from fabiankaegy fabiankaegy will be requested when the pull request is marked ready for review fabiankaegy is a code owner

Assignees
No one assigned
Labels
[Block] Separator Affects the Separator Block [Status] In Progress Tracking issues with work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Controlling the height of the Separator block
1 participant
@simison