Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format library: use hooks for all components #26779

Merged
merged 3 commits into from
Nov 6, 2020
Merged

Conversation

ellatrix
Copy link
Member

@ellatrix ellatrix commented Nov 6, 2020

Description

Needed for a PR to introduce useAnchorRef (to share code between link, image and text colour and make it iframe compatible).
Plugin authors probably copy this code for other formats, so it's good to simplify it with hooks.

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@github-actions
Copy link

github-actions bot commented Nov 6, 2020

Size Change: -693 B (0%)

Total Size: 1.21 MB

Filename Size Change
build/api-fetch/index.js 3.45 kB -2 B (0%)
build/block-directory/index.js 8.72 kB -1 B
build/block-editor/index.js 133 kB +3 B (0%)
build/block-library/editor-rtl.css 8.96 kB -57 B (0%)
build/block-library/editor.css 8.96 kB -53 B (0%)
build/block-library/index.js 147 kB +221 B (0%)
build/block-library/style-rtl.css 8.03 kB +49 B (0%)
build/block-library/style.css 8.03 kB +51 B (0%)
build/components/index.js 172 kB +8 B (0%)
build/data/index.js 8.8 kB +28 B (0%)
build/date/index.js 31.8 kB +2 B (0%)
build/edit-navigation/index.js 11.2 kB +4 B (0%)
build/edit-post/index.js 306 kB -3 B (0%)
build/edit-site/index.js 22.6 kB +1 B
build/edit-widgets/index.js 26.3 kB +2 B (0%)
build/format-library/index.js 6.76 kB -949 B (14%) 👏
build/list-reusable-blocks/index.js 3.11 kB +1 B
build/media-utils/index.js 5.34 kB +2 B (0%)
build/plugins/index.js 2.56 kB -1 B
build/rich-text/index.js 13.2 kB -1 B
build/server-side-render/index.js 2.77 kB +2 B (0%)
ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.14 kB 0 B
build/annotations/index.js 3.78 kB 0 B
build/autop/index.js 2.84 kB 0 B
build/blob/index.js 665 B 0 B
build/block-directory/style-rtl.css 943 B 0 B
build/block-directory/style.css 942 B 0 B
build/block-editor/style-rtl.css 11.2 kB 0 B
build/block-editor/style.css 11.2 kB 0 B
build/block-library/theme-rtl.css 792 B 0 B
build/block-library/theme.css 793 B 0 B
build/block-serialization-default-parser/index.js 1.88 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/blocks/index.js 48.1 kB 0 B
build/components/style-rtl.css 15.3 kB 0 B
build/components/style.css 15.3 kB 0 B
build/compose/index.js 9.81 kB 0 B
build/core-data/index.js 12.5 kB 0 B
build/data-controls/index.js 772 B 0 B
build/deprecated/index.js 768 B 0 B
build/dom-ready/index.js 571 B 0 B
build/dom/index.js 4.46 kB 0 B
build/edit-navigation/style-rtl.css 881 B 0 B
build/edit-navigation/style.css 885 B 0 B
build/edit-post/style-rtl.css 6.41 kB 0 B
build/edit-post/style.css 6.39 kB 0 B
build/edit-site/style-rtl.css 3.91 kB 0 B
build/edit-site/style.css 3.91 kB 0 B
build/edit-widgets/style-rtl.css 3.12 kB 0 B
build/edit-widgets/style.css 3.12 kB 0 B
build/editor/editor-styles-rtl.css 480 B 0 B
build/editor/editor-styles.css 482 B 0 B
build/editor/index.js 42.8 kB 0 B
build/editor/style-rtl.css 3.85 kB 0 B
build/editor/style.css 3.85 kB 0 B
build/element/index.js 4.65 kB 0 B
build/escape-html/index.js 735 B 0 B
build/format-library/style-rtl.css 547 B 0 B
build/format-library/style.css 548 B 0 B
build/hooks/index.js 2.16 kB 0 B
build/html-entities/index.js 623 B 0 B
build/i18n/index.js 3.57 kB 0 B
build/is-shallow-equal/index.js 712 B 0 B
build/keyboard-shortcuts/index.js 2.52 kB 0 B
build/keycodes/index.js 1.94 kB 0 B
build/list-reusable-blocks/style-rtl.css 476 B 0 B
build/list-reusable-blocks/style.css 476 B 0 B
build/notices/index.js 1.79 kB 0 B
build/nux/index.js 3.42 kB 0 B
build/nux/style-rtl.css 671 B 0 B
build/nux/style.css 668 B 0 B
build/primitives/index.js 1.43 kB 0 B
build/priority-queue/index.js 791 B 0 B
build/redux-routine/index.js 2.85 kB 0 B
build/reusable-blocks/index.js 3.06 kB 0 B
build/shortcode/index.js 1.69 kB 0 B
build/token-list/index.js 1.27 kB 0 B
build/url/index.js 4.06 kB 0 B
build/viewport/index.js 1.84 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.22 kB 0 B

compressed-size-action

@ellatrix ellatrix added the [Type] Code Quality Issues or PRs that relate to code quality label Nov 6, 2020
@ellatrix ellatrix merged commit df0f62e into master Nov 6, 2020
@ellatrix ellatrix deleted the try/format-lib-use-hooks branch November 6, 2020 17:03
@github-actions github-actions bot added this to the Gutenberg 9.4 milestone Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant