Chore: Fix: Pass clearable setting on ColorGradientControl. #26784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
the
[Type] Bug
|
Size Change: +12 B (0%) Total Size: 1.21 MB
ℹ️ View Unchanged
|
jorgefilipecosta
deleted the
fix/pass-clearable-setting-on-ColorGradientControl
branch
oandregal
added
the
[Feature] Design Tools
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The setting clearable was not being passed to the color palette from ColorGradientControl. This setting should be passed as the other settings are. In global styles, we will need this setting because when the theme sets a default color, and the user did not set any color, we want to show the mark that there is a color, but we don't want to allow the user to clear it, we allow the user to change to another one.