Add template part conversion e2e tests #26788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addison-Stavlo
added
[Status] In Progress
Addison-Stavlo
requested review from
ajitbohra,
nerrad,
ntwb and
talldan
as code owners
|
Size Change: -988 B (0%) Total Size: 1.21 MB
ℹ️ View Unchanged
|
Addison-Stavlo
requested review from
david-szabo97,
noahtallen,
vindl,
mattwiebe,
Copons and
jeyip
Addison-Stavlo
changed the title
Addison-Stavlo
removed
the
[Status] In Progress
Addison-Stavlo
force-pushed
the
add/template-part-conversion-tests
branch
from
b086dc5 to
db3f167
Compare
noahtallen
approved these changes
Nov 6, 2020
Perhaps. Do you mean to multi-select a couple blocks for converting to template part (instead of just the one)? I suppose the test could select one, verify the option is there, multi select and convert and then verify it was converted with all the blocks? Or alternatively have 2 separate tests for block conversion vs. multiple block conversion? 🤔 |
I guess that might be "more robust", but yeah, selecting multiple blocks before converting is what I was getting at |
👌 - Sounds good. I added another test for doing the same with a multi-selection, and refactored a little bit. Could use another 👀 glance and 👍 at some point for a sanity check. Also rerunning the CI tests here a couple times to be sure things are good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding tests for convert/detach template part flows that were added in #20445 / #26488
How has this been tested?
Tested by running the new tests locally as well as verifying they are doing as expected in interactive/slow-mo mode.
Screenshots
Types of changes
Checklist: