-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Encourage the use of npm ci to avoid package-lock conflict #26837
Conversation
Size Change: 0 B Total Size: 1.21 MB ℹ️ View Unchanged
|
We had some issues with |
Just confirmed the following worked fine for me locally, no errors:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI jobs pass as well. Let's give it a try and see how it goes 👍
Description
The recent package-lock conflicts highlighted that we should be using
npm ci
to make sure setups are being pulled in from the package-lock.json and not updating packages a developer might be unintending too.Also updated the zip build to use
npm ci
See the documentation at: https://docs.npmjs.com/cli/v6/commands/npm-ci
How has this been tested?
npm ci
instead ofnpm install
will not update package.json or any dependencies and only use the packages specified in the package-lock.json givingTypes of changes
Update docs to use
npm ci
and update build zip script to usenpm ci