Fix Fatal for unregistered taxonomy (#26851) #26854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbingwide
requested review from
ajitbohra,
Soean and
talldan
as code owners
gziolo
added
[Block] Post Terms
gziolo
approved these changes
Nov 14, 2020
There was a problem hiding this comment.
Thanks for catching this one. I see that you are right about get_the_terms and its return value.
Should we add this check to the existing condition?
| @@ -19,6 +19,9 @@ function render_block_core_post_hierarchical_terms( $attributes, $content, $bloc | |||
| } | |||
|
|
|||
| $post_hierarchical_terms = get_the_terms( $block->context['postId'], $attributes['term'] ); | |||
| if ( is_wp_error( $post_hierarchical_terms ) ) { | |||
| return ''; | |||
| } | |||
| if ( empty( $post_hierarchical_terms ) ) { | |||
There was a problem hiding this comment.
This new condition could be combined with empty check.
There was a problem hiding this comment.
Agreed. What do the coding guidelines say?
There was a problem hiding this comment.
I'm not aware of coding styles that cover it. I can merge as is if you prefer.
There was a problem hiding this comment.
Yes please. Then I can continue working on PRs for other issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the
core/post-hierarchical-termsblock has been passed an invalid taxonomy name for thetermattribute it produced a Fatal error due to not detecting a WordPress error (WP_errorobject ) returned fromget_the_terms().This fix adds an
is_wp_error()test, returning an empty string when detected.How has this been tested?
Tested with Twenty Twenty-One Blocks in WordPress 5.6-beta3
I manually created a post using the code editor containing.
Prior to applying the fix I got the Fatal error.
After applying the fix the output showed the taxonomy terms associated with Categories.
There was no visible output for the unknown taxonomy.
With the fix applied the post could be viewed and edited, using both the Code and Visual editor.
Screenshots
Types of changes
Fixes #26851
Checklist: